Reserve part of the ring buffer for high priority events#451
Conversation
Benchmark results for collatzParameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. See unchanged results
|
Benchmark results for BadBoggleSolver_runParameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. See unchanged results
|
0c57a32 to
2be56e4
Compare
| MPSCRingBufferWriter writer{&_pevent.rb, _high_priority_area_size}; | ||
| bool notify_consumer{false}; | ||
|
|
||
| bool timeout = false; |
There was a problem hiding this comment.
I think you meant to reserve as high priority ?
There was a problem hiding this comment.
Indeed, thanks for the fix !
2be56e4 to
6604a11
Compare
|
Through simple malloc I'm not able to see an improvement of lost dealloc events. I'll hold off on merging this until we have a bench showing that it is saving dealloc events. |
Do you see no improvements because you do not observe lost dealloc events without this change or because you still see lost dealloc event with this change ? Note that the library does not report its state upon exit and therefore the stats reported by ddprof on lost events might be incorrect if simple_malloc runs for less than a profiling period. I have a patch to improve this. I am testing with |
Deallocation events and clear live allocation events are considered high priority and can used the high priority area.
10ea097 to
8b33723
Compare
2 participants
What does this PR do?
Deallocation events and clear live allocation events are considered high priority and can used the high priority area.