Send lost (de)alloc events as part of state#450
Merged
Conversation
nsavoire
force-pushed
the
nsavoire/send_lost_events_in_tracker_state
branch
from
October 16, 2025 13:38
4a031c0 to
505ae55
Compare
Benchmark results for collatzParameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. See unchanged results
|
Benchmark results for BadBoggleSolver_runParameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. See unchanged results
|
nsavoire
force-pushed
the
nsavoire/send_lost_events_in_tracker_state
branch
from
October 16, 2025 14:12
505ae55 to
88d0722
Compare
r1viollet
approved these changes
Oct 17, 2025
r1viollet
left a comment
r1viollet
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
Good idea to reduce pressure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Stop sending lost (de)alloc events, instead send the (de)alloc stats as part of allocation tracker state.