Skip to content

Fix size errors in structs and avoid sending keeping an address if ring buffer is full#448

Merged
nsavoire merged 1 commit into
mainfrom
nsavoire/fix_size_errors
Oct 16, 2025
Merged

Fix size errors in structs and avoid sending keeping an address if ring buffer is full#448
nsavoire merged 1 commit into
mainfrom
nsavoire/fix_size_errors

Conversation

@nsavoire

Copy link
Copy Markdown
Collaborator

What does this PR do?

  • Use correct size for structs when pushing in ring buffer
  • When push of allocation event fail because buffer is full, do not track the address

@nsavoire
nsavoire requested a review from r1viollet as a code owner October 16, 2025 12:09

@r1viollet r1viollet left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pr-commenter

pr-commenter Bot commented Oct 16, 2025

Copy link
Copy Markdown

Benchmark results for collatz

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.20.0+ea712fb9.79135437 ddprof 0.20.0+c68c1a45.79482612

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-collatz --preset cpu_only collatz_runner.sh same

@pr-commenter

pr-commenter Bot commented Oct 16, 2025

Copy link
Copy Markdown

Benchmark results for BadBoggleSolver_run

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.20.0+ea712fb9.79135437 ddprof 0.20.0+c68c1a45.79482612

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-bad-boggle-solver BadBoggleSolver_run work 1000 same

@nsavoire
nsavoire merged commit d8cbe65 into main Oct 16, 2025
2 checks passed
@nsavoire
nsavoire deleted the nsavoire/fix_size_errors branch October 16, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants