Skip to content

Deprecate global option#444

Merged
r1viollet merged 1 commit into
mainfrom
r1viollet/deprecate_global_option
Aug 7, 2025
Merged

Deprecate global option#444
r1viollet merged 1 commit into
mainfrom
r1viollet/deprecate_global_option

Conversation

@r1viollet

@r1viollet r1viollet commented Aug 7, 2025

Copy link
Copy Markdown
Collaborator

What does this PR do?

Redirect users to DataDog/dd-otel-host-profiler

Motivation

Avoid supporting the global option.
Ensure users have a better experience with full host profiling.

Additional Notes

NA

How to test the change?

NA

@r1viollet
r1viollet requested a review from nsavoire as a code owner August 7, 2025 08:12
@pr-commenter

pr-commenter Bot commented Aug 7, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmark results for collatz

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.20.0+6952c106.72736643 ddprof 0.20.0+6365469f.72953543

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-collatz --preset cpu_only collatz_runner.sh same

@pr-commenter

pr-commenter Bot commented Aug 7, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmark results for BadBoggleSolver_run

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.20.0+6952c106.72736643 ddprof 0.20.0+6365469f.72953543

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-bad-boggle-solver BadBoggleSolver_run work 1000 same

@r1viollet r1viollet mentioned this pull request Aug 7, 2025
Open
1 task
nsavoire
nsavoire previously approved these changes Aug 7, 2025
View reviewed changes
@r1viollet
Deprecate global option
6365469 
Redirect users to DataDog/dd-otel-host-profiler
@r1viollet
r1viollet force-pushed the r1viollet/deprecate_global_option branch from 295296b to 6365469 Compare August 7, 2025 08:48
@r1viollet

r1viollet commented Aug 7, 2025

Copy link
Copy Markdown
Collaborator Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Aug 7, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-08-07 08:54:47 UTC ℹ️ Start processing command /merge

2025-08-07 08:54:54 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-08-07 09:50:32 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

@r1viollet

r1viollet commented Aug 7, 2025

Copy link
Copy Markdown
Collaborator Author

/remove

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Aug 7, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-08-07 09:50:27 UTC ℹ️ Start processing command /remove

2025-08-07 09:50:30 UTC ℹ️ Devflow: /remove

@r1viollet
r1viollet merged commit a69c81b into main Aug 7, 2025
2 of 3 checks passed
@r1viollet
r1viollet deleted the r1viollet/deprecate_global_option branch August 7, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nsavoire nsavoire nsavoire approved these changes

Assignees

@nsavoire nsavoire

Labels

mergequeue-status: removed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@r1viollet @nsavoire