Update build dependencies#443
Merged
Merged
Conversation
- elfutils 0.192
r1viollet
force-pushed
the
r1viollet/update_elfutils
branch
5 times, most recently
from
August 4, 2025 12:46
0e1a814 to
6a7fda6
Compare
r1viollet
force-pushed
the
r1viollet/update_elfutils
branch
from
August 4, 2025 13:06
6a7fda6 to
bd0f5ec
Compare
r1viollet
commented
Aug 5, 2025
| const ElfW(Sym) *s = nullptr; | ||
| // NOLINTBEGIN(bugprone-suspicious-stringview-data-usage) | ||
| if (dyn_info.gnu_hash) { | ||
| s = gnu_hash_lookup(dyn_info.strtab.data(), dyn_info.symtab.data(), |
Collaborator
Author
There was a problem hiding this comment.
I'm not sure if we could fix this in a cleaner way
r1viollet
marked this pull request as ready for review
August 5, 2025 08:03
Benchmark results for collatzParameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. See unchanged results
|
Benchmark results for BadBoggleSolver_runParameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. See unchanged results
|
libclang_rt is in the linux folder. Usually located here: /usr/lib/llvm-20/lib/clang/20/lib/linux/libclang_rt.asan-x86_64.so Ensure we can link against it.
Manual fetch of valgrind is no longer needed in the build image
r1viollet
force-pushed
the
r1viollet/update_elfutils
branch
from
August 5, 2025 12:59
3e0f9f2 to
49676aa
Compare
nsavoire
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update build dependencies.
Fix linter issues or add NOLINT options.
Motivation
Ensure builds are done with
Ensure that we can build the main branch.
Additional Notes
This requires a PR in ddprof-build to update build caches.
How to test the change?
Already tested