Skip to content

libdatadog version 19.1.0#440

Merged
r1viollet merged 3 commits into
mainfrom
r1viollet/libdatadog_19.1.0
Jul 24, 2025
Merged

libdatadog version 19.1.0#440
r1viollet merged 3 commits into
mainfrom
r1viollet/libdatadog_19.1.0

Conversation

@r1viollet

@r1viollet r1viollet commented Jul 22, 2025

Copy link
Copy Markdown
Collaborator

What does this PR do?

  • Upgrade APIs to libdatadog 19.1.0
  • Remove upload of a file
    This was not needed in more recent APIs of libdatadog

Motivation

Keep up to date with recent libdatadog versions

Additional Notes

NA

How to test the change?

Describe here in detail how the change can be validated. This is a great section to call out specific tests you've added or improved, or to acknowledge code sections which are particularly difficult to test.

- Introduce a start time
@pr-commenter

pr-commenter Bot commented Jul 22, 2025

Copy link
Copy Markdown

Benchmark results for collatz

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.19.0+6c58be2c.65352852 ddprof 0.19.0+f7df1e15.71563865

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-collatz --preset cpu_only collatz_runner.sh same

@pr-commenter

pr-commenter Bot commented Jul 22, 2025

Copy link
Copy Markdown

Benchmark results for BadBoggleSolver_run

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.19.0+6c58be2c.65352852 ddprof 0.19.0+f7df1e15.71563865

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-bad-boggle-solver BadBoggleSolver_run work 1000 unsure
[+9.799ms; +32.249ms] or [+0.503%; +1.654%]

@r1viollet
r1viollet force-pushed the r1viollet/libdatadog_19.1.0 branch from 20a68f6 to 4dfd6f6 Compare July 22, 2025 15:23
@r1viollet
r1viollet force-pushed the r1viollet/libdatadog_19.1.0 branch from 4dfd6f6 to fd20aef Compare July 22, 2025 16:02
@r1viollet
r1viollet marked this pull request as ready for review July 23, 2025 07:09
@r1viollet
r1viollet requested a review from nsavoire as a code owner July 23, 2025 07:09
Comment thread src/exporter/ddprof_exporter.cc Outdated
Comment thread src/exporter/ddprof_exporter.cc
@r1viollet
r1viollet marked this pull request as draft July 23, 2025 12:59
@r1viollet
r1viollet marked this pull request as ready for review July 24, 2025 11:12
Comment thread src/pprof/ddprof_pprof.cc
- The start time is optional and is inferred from libdatadog
@r1viollet
r1viollet force-pushed the r1viollet/libdatadog_19.1.0 branch from 811fed0 to f7df1e1 Compare July 24, 2025 11:37
@r1viollet
r1viollet requested a review from nsavoire July 24, 2025 11:49
@r1viollet
r1viollet merged commit 0f8a6da into main Jul 24, 2025
2 checks passed
@r1viollet
r1viollet deleted the r1viollet/libdatadog_19.1.0 branch July 24, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants