Skip to content

Presets - add an allocation live heap preset#437

Merged
r1viollet merged 1 commit into
mainfrom
r1viollet/alloc_only
May 16, 2025
Merged

Presets - add an allocation live heap preset#437
r1viollet merged 1 commit into
mainfrom
r1viollet/alloc_only

Conversation

@r1viollet

Copy link
Copy Markdown
Collaborator

What does this PR do?

Add a preset that just allows for allocation and heap profiling

Motivation

We now provide CPU profiling through the host profiler.
This preset allows users to only get allocations and heap profiles.

Additional Notes

NA

How to test the change?

I added a unit test and checked in our product for the expected.
image

@r1viollet
r1viollet requested a review from nsavoire as a code owner May 16, 2025 08:29
@r1viollet
r1viollet force-pushed the r1viollet/alloc_only branch 2 times, most recently from 296a46d to b9a7d7f Compare May 16, 2025 09:00
@r1viollet
r1viollet force-pushed the r1viollet/alloc_only branch from b9a7d7f to 84c4f55 Compare May 16, 2025 12:35
@pr-commenter

pr-commenter Bot commented May 16, 2025

Copy link
Copy Markdown

Benchmark results for collatz

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.19.0+b2a562b9.62071247 ddprof 0.19.0+84c4f554.65316231

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-collatz --preset cpu_only collatz_runner.sh same

@pr-commenter

pr-commenter Bot commented May 16, 2025

Copy link
Copy Markdown

Benchmark results for BadBoggleSolver_run

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.19.0+b2a562b9.62071247 ddprof 0.19.0+84c4f554.65316231

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-bad-boggle-solver BadBoggleSolver_run work 1000 same

@r1viollet
r1viollet merged commit 6c58be2 into main May 16, 2025
@r1viollet
r1viollet deleted the r1viollet/alloc_only branch May 16, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants