Timeline thread names#427
Merged
Merged
Conversation
r1viollet
commented
Oct 7, 2024
|
|
||
| void add_container_id(Process &process, UnwindState *us) { | ||
| auto container_id = process.get_container_id(); | ||
| const auto &container_id = process.get_container_id(); |
Collaborator
Author
There was a problem hiding this comment.
This is slightly controversial, though the lifetime of the container ID should be tied to the process, which will outlive the aggregation of the sample
nsavoire
previously approved these changes
Oct 7, 2024
Collaborator
|
Build is failing |
r1viollet
force-pushed
the
r1viollet/timeline_thread_names
branch
from
October 7, 2024 16:28
e63d57b to
86bf3c1
Compare
r1viollet
force-pushed
the
r1viollet/timeline_thread_names
branch
from
October 8, 2024 07:43
86bf3c1 to
3e62c18
Compare
Benchmark results for collatzParameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. See unchanged results
|
Benchmark results for BadBoggleSolver_runParameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. See unchanged results
|
Collaborator
Author
Thanks, I think we are fine now. |
nsavoire
approved these changes
Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ensure we have thread names / process name in the timeline
Motivation
This makes the timeline easier to read
Additional Notes
This has some amount of overhead
I left the timeline trigger to allow the fallback
There is no new lookup if we have a thread name change.
How to test the change?
Using timeline you should know see thread names.