Skip to content

Ubuntu 24 including LLVM 18#426

Merged
r1viollet merged 4 commits into
mainfrom
r1viollet/llvm-18
Oct 1, 2024
Merged

Ubuntu 24 including LLVM 18#426
r1viollet merged 4 commits into
mainfrom
r1viollet/llvm-18

Conversation

@r1viollet

Copy link
Copy Markdown
Collaborator

What does this PR do?

Ubuntu 24
LLVM 18

Motivation

Fix asan builds

Additional Notes

NA

How to test the change?

The main branch should be green again

- Add an option for ubuntu 24 in dockerfile
- Update llvm installer (to include version 18)
Adjust aws and pip install commands
nsavoire
nsavoire previously approved these changes Sep 26, 2024
@pr-commenter

pr-commenter Bot commented Sep 26, 2024

Copy link
Copy Markdown

Benchmark results for collatz

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.18.0+5849ebfa.39514389 ddprof 0.18.0+ec94c023.45489824

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-collatz --preset cpu_only collatz_runner.sh same

@pr-commenter

pr-commenter Bot commented Sep 26, 2024

Copy link
Copy Markdown

Benchmark results for BadBoggleSolver_run

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.18.0+5849ebfa.39514389 ddprof 0.18.0+ec94c023.45489824

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-bad-boggle-solver BadBoggleSolver_run work 1000 same

@r1viollet
r1viollet force-pushed the r1viollet/llvm-18 branch 2 times, most recently from 9ae0c63 to 38478b4 Compare September 30, 2024 07:19
@r1viollet

Copy link
Copy Markdown
Collaborator Author

@r1viollet
r1viollet requested a review from nsavoire September 30, 2024 10:03
nsavoire
nsavoire previously approved these changes Sep 30, 2024
Comment thread include/enum_flags.hpp Outdated
Comment thread include/enum_flags.hpp Outdated
@r1viollet
r1viollet merged commit aa511bc into main Oct 1, 2024
@r1viollet
r1viollet deleted the r1viollet/llvm-18 branch October 1, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants