Skip to content

Reorder events by default#418

Merged
nsavoire merged 1 commit into
mainfrom
nsavoire/reoder_events_by_default
Jul 17, 2024
Merged

Reorder events by default#418
nsavoire merged 1 commit into
mainfrom
nsavoire/reoder_events_by_default

Conversation

@nsavoire

Copy link
Copy Markdown
Collaborator

What does this PR do?

Enable event reordering by default.

@pr-commenter

pr-commenter Bot commented Jul 17, 2024

Copy link
Copy Markdown

Benchmark results for collatz

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.18.0+fbf71d5a.39261263 ddprof 0.18.0+7b5a91d4.39425376

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-collatz --preset cpu_only collatz_runner.sh same

@pr-commenter

pr-commenter Bot commented Jul 17, 2024

Copy link
Copy Markdown

Benchmark results for BadBoggleSolver_run

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.18.0+fbf71d5a.39261263 ddprof 0.18.0+7b5a91d4.39425376

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-bad-boggle-solver BadBoggleSolver_run work 1000 unsure
[+0.407ms; +8.639ms] or [+0.017%; +0.357%]

@r1viollet r1viollet left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nsavoire
nsavoire merged commit 6fb2376 into main Jul 17, 2024
@nsavoire
nsavoire deleted the nsavoire/reoder_events_by_default branch July 17, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants