Timeline ON by default#417
Merged
Merged
Conversation
Benchmark results for collatzParameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. See unchanged results
|
Benchmark results for BadBoggleSolver_runParameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. See unchanged results
|
r1viollet
force-pushed
the
r1viollet/adjust_defaults
branch
from
July 16, 2024 12:19
8fa7a37 to
bcda9fd
Compare
sanchda
previously approved these changes
Jul 16, 2024
| ->envname("DD_PROFILING_INLINED_FUNCTIONS"); | ||
| app.add_flag("--timeline,-t", timeline, | ||
|
|
||
| app.add_flag("--timeline,!--no-timeline", timeline, |
Contributor
There was a problem hiding this comment.
I'm stunned. This is an incredibly expressive library!
- Adjust timeline as ON by default - bump version to 0.18.0
r1viollet
force-pushed
the
r1viollet/adjust_defaults
branch
from
July 16, 2024 12:27
bcda9fd to
7e50c29
Compare
nsavoire
approved these changes
Jul 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Ensure users discover the timeline feature
Additional Notes
We should monitor the increase in memory usage in relenv
How to test the change?
Prof-correctness can have some timestamp tests