Skip to content

configuration update for inlined functions#414

Merged
r1viollet merged 1 commit into
mainfrom
r1viollet/inlined_function_env_var
Jul 4, 2024
Merged

configuration update for inlined functions#414
r1viollet merged 1 commit into
mainfrom
r1viollet/inlined_function_env_var

Conversation

@r1viollet

Copy link
Copy Markdown
Collaborator

What does this PR do?

Add an environment variable to allow the setting of the inlined functions setting

Motivation

A user wanted this to be possible

Additional Notes

NA

How to test the change?

export DD_PROFILING_INLINED_FUNCTIONS=true
./ddprof --show_config -l notice ~/dd/bad-boggle-solver/build/src/BadBoggleSolver_run work 1000

@pr-commenter

pr-commenter Bot commented Jul 1, 2024

Copy link
Copy Markdown

Benchmark results for collatz

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.17.1+fd57d2c9.37318613 ddprof 0.17.1+e0da273d.38045097

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-collatz --preset cpu_only collatz_runner.sh same

@pr-commenter

pr-commenter Bot commented Jul 1, 2024

Copy link
Copy Markdown

Benchmark results for BadBoggleSolver_run

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.17.1+fd57d2c9.37318613 ddprof 0.17.1+e0da273d.38045097

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-bad-boggle-solver BadBoggleSolver_run work 1000 same

nsavoire
nsavoire previously approved these changes Jul 1, 2024
- Add an environment variable
@r1viollet
r1viollet force-pushed the r1viollet/inlined_function_env_var branch from a1483be to e0da273 Compare July 1, 2024 19:15
@r1viollet
r1viollet requested a review from nsavoire July 4, 2024 09:01
@r1viollet
r1viollet merged commit 15af4f1 into main Jul 4, 2024
@r1viollet
r1viollet deleted the r1viollet/inlined_function_env_var branch July 4, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants