Virtual frame adjustement - Filename only#413
Merged
Conversation
Benchmark results for collatzParameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. See unchanged results
|
Benchmark results for BadBoggleSolver_runParameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. See unchanged results
|
nsavoire
previously approved these changes
Jun 13, 2024
Adjust binary and DSO frames to only keep the filename instead of the full path This makes the flamegraphs easier to read
r1viollet
force-pushed
the
r1viollet/adjust_exe_base_name
branch
from
June 18, 2024 08:49
650f4ad to
6022830
Compare
nsavoire
approved these changes
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adjust binary and DSO frames to only keep the filename instead of the full path This makes the flamegraphs easier to read
Motivation
Consistency with Otel profiler
Additional Notes
NA
How to test the change?
This is mostly a cosmetic change. The top frame for instance does not include the full path.
Prof correctness could be used for this.