Skip to content

Doc update: Worker period flag for leak investigations#408

Merged
r1viollet merged 1 commit into
mainfrom
r1viollet/live_heap_worker_period
May 7, 2024
Merged

Doc update: Worker period flag for leak investigations#408
r1viollet merged 1 commit into
mainfrom
r1viollet/live_heap_worker_period

Conversation

@r1viollet

Copy link
Copy Markdown
Collaborator

What does this PR do?

Add a note around worker period for leak investigations

Motivation

This is a gotcha that we should fix. In the mean time we can document it.

Additional Notes

NA

How to test the change?

NA

@r1viollet
r1viollet requested review from nsavoire and sanchda as code owners May 2, 2024 07:38
@pr-commenter

pr-commenter Bot commented May 2, 2024

Copy link
Copy Markdown

Benchmark results for collatz

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.17.1+43a02070.32344779 ddprof 0.17.1+f0eba5c2.33407374

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-collatz --preset cpu_only collatz_runner.sh same

@pr-commenter

pr-commenter Bot commented May 2, 2024

Copy link
Copy Markdown

Benchmark results for BadBoggleSolver_run

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.17.1+43a02070.32344779 ddprof 0.17.1+f0eba5c2.33407374

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-bad-boggle-solver BadBoggleSolver_run work 1000 same

@r1viollet
r1viollet merged commit 19cf5fd into main May 7, 2024
@r1viollet
r1viollet deleted the r1viollet/live_heap_worker_period branch May 7, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants