Skip to content

[PROF-15412] Bump minimum version of datadog-ruby_core_source to 3.5.3#6047

Merged
eregon merged 1 commit into
masterfrom
ivoanjo/prof-15412-ruby4_0_6-support
Jul 15, 2026
Merged

[PROF-15412] Bump minimum version of datadog-ruby_core_source to 3.5.3#6047
eregon merged 1 commit into
masterfrom
ivoanjo/prof-15412-ruby4_0_6-support

Conversation

@ivoanjo

@ivoanjo ivoanjo commented Jul 15, 2026

Copy link
Copy Markdown
Member

What does this PR do?

This PR bumps the minimum version of the datadog-ruby_core_source gem to the latest version (3.5.3), having the usual diff (e.g. #5278 was the previous update).

Motivation:

Doing this bump forces updates to the datadog gem to also pull in the latest version of the datadog-ruby_core_source gem. This ensures users have the best experience and don't e.g. run into issues because somehow they're running the latest version of the gem with an outdated version of the headers.

Specifically version 3.5.3 adds support for Ruby 4.0.6, fixing #6045 .

Change log entry

Yes. Profiling: Fix Ruby 4.0.6 support by bumping minimum version of datadog-ruby_core_source to 3.5.3

Additional Notes:

N/A

How to test the change?

This will fix the "test-asan" check failing in master (e.g. https://github.com/DataDog/dd-trace-rb/actions/runs/29363868729 ) because test-asan is running on 4.0.6, so green CI is good.

Also, I've locally tested with both Ruby 4.0.5 and 4.0.6 (see DataDog/datadog-ruby_core_source#28 ).

@ivoanjo
[PROF-15412] Bump minimum version of datadog-ruby_core_source to 3.5.3
56d3a9e 
**What does this PR do?**

This PR bumps the minimum version of the datadog-ruby_core_source gem to
the latest version (3.5.3), having the usual diff (e.g.
#5278 was the previous
update).

**Motivation:**

Doing this bump forces updates to the datadog gem to also pull in the
latest version of the datadog-ruby_core_source gem. This ensures users
have the best experience and don't e.g. run into issues because somehow
they're running the latest version of the gem with an outdated version
of the headers.

Specifically version 3.5.3 adds support for Ruby 4.0.6, fixing
#6045 .

**Additional Notes:**

N/A

**How to test the change?**

This will fix the "test-asan" check failing in master (e.g.
https://github.com/DataDog/dd-trace-rb/actions/runs/29363868729 )
because test-asan is running on 4.0.6, so green CI is good.

Also, I've locally tested with both Ruby 4.0.5 and 4.0.6 (see
DataDog/datadog-ruby_core_source#28 ).
@ivoanjo
ivoanjo requested a review from a team as a code owner July 15, 2026 10:13
@ivoanjo
ivoanjo requested review from a team and eregon July 15, 2026 10:13
@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Jul 15, 2026 •
edited by datadog-prod-us1-5 Bot
Loading

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 89.89% (-0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 56d3a9e | Docs | Datadog PR Page | Give us feedback!

@pr-commenter

pr-commenter Bot commented Jul 15, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-07-15 10:38:12

Comparing candidate commit 56d3a9e in PR branch ivoanjo/prof-15412-ruby4_0_6-support with baseline commit 97cc6f6 in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 1 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:tracing - trace.to_digest - Continue

  • unstable throughput [-1666.227op/s; +1462.985op/s] or [-5.744%; +5.043%]

@eregon
eregon merged commit 382717d into master Jul 15, 2026
597 checks passed
@eregon
eregon deleted the ivoanjo/prof-15412-ruby4_0_6-support branch July 15, 2026 12:22
@dd-octo-sts dd-octo-sts Bot added this to the 2.38.0 milestone Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eregon eregon eregon approved these changes
@TonyCTHsu TonyCTHsu TonyCTHsu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.38.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ivoanjo @eregon @TonyCTHsu