Skip to content

[APPSEC-68561] Fix Rack/Rails body parsing on exception#5993

Merged
Strech merged 2 commits into
masterfrom
appsec-68561-fix-rails-body-parsing-exception
Jul 6, 2026
Merged

[APPSEC-68561] Fix Rack/Rails body parsing on exception#5993
Strech merged 2 commits into
masterfrom
appsec-68561-fix-rails-body-parsing-exception

Conversation

@Strech

@Strech Strech commented Jul 3, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Add safe-guard for request body parsing classes

Motivation:

Fix APPSEC-68561

Change log entry

Yes. Fix Rack-based and Rails request body analysis when body parsing fails

Additional Notes:

None.

How to test the change?

CI

@Strech
Strech requested review from a team as code owners July 3, 2026 15:14
@dd-octo-sts dd-octo-sts Bot added integrations Involves tracing integrations appsec Application Security monitoring product labels Jul 3, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Typing analysis

Note: Ignored files are excluded from the next sections.

Untyped methods

This PR clears 1 partially typed method. It increases the percentage of typed methods from 65.77% to 65.81% (+0.04%).

Partially typed methods (+0-1)Cleared:
sig/datadog/appsec/utils/http/body_reader.rbs:6
└── def self?.read: (untyped body, limit: Integer, ?rewind_before_read: bool) -> String?

@Strech
Strech enabled auto-merge July 3, 2026 15:16
@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Jul 3, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 90.05% (+0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 69c1cc8 | Docs | Datadog PR Page | Give us feedback!

@Strech
Strech disabled auto-merge July 6, 2026 14:09
@Strech
Strech merged commit effb529 into master Jul 6, 2026
589 checks passed
@Strech
Strech deleted the appsec-68561-fix-rails-body-parsing-exception branch July 6, 2026 14:10
@dd-octo-sts dd-octo-sts Bot added this to the 2.38.0 milestone Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

appsec Application Security monitoring product integrations Involves tracing integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants