Skip to content

[APPSEC-68662] Fix cached request body analysis for Rack and Sinatra#5991

Merged
Strech merged 1 commit into
masterfrom
appsec-68662-fix-rack-sinatra-cached-body-handling
Jul 3, 2026
Merged

[APPSEC-68662] Fix cached request body analysis for Rack and Sinatra#5991
Strech merged 1 commit into
masterfrom
appsec-68662-fix-rack-sinatra-cached-body-handling

Conversation

@Strech

@Strech Strech commented Jul 3, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Fix WAF analysis for requests with already parsed/cached bodies that are impossible to read

Motivation:

Fix APPSEC-68662

Change log entry

Yes. Fix WAF request analysis for cached/parsed bodies in Rack and Sinatra

Additional Notes:

None.

How to test the change?

CI

@Strech
Strech requested a review from a team as a code owner July 3, 2026 13:40
@dd-octo-sts dd-octo-sts Bot added integrations Involves tracing integrations appsec Application Security monitoring product labels Jul 3, 2026
@Strech
Strech enabled auto-merge July 3, 2026 13:43

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 217d94e437

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread lib/datadog/appsec/contrib/rack/gateway/watcher.rb
@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented Jul 3, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 90.03% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 217d94e | Docs | Datadog PR Page | Give us feedback!

@Strech
Strech merged commit 33c4c2b into master Jul 3, 2026
589 checks passed
@Strech
Strech deleted the appsec-68662-fix-rack-sinatra-cached-body-handling branch July 3, 2026 14:00
@dd-octo-sts dd-octo-sts Bot added this to the 2.37.0 milestone Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

appsec Application Security monitoring product integrations Involves tracing integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants