Skip to content

[APPSEC-68774] Add Kit::AppSec::Events::V2#track_user_signup#5973

Merged
Strech merged 1 commit into
masterfrom
appsec-68774-kit-sdk-v2-signup
Jul 1, 2026
Merged

[APPSEC-68774] Add Kit::AppSec::Events::V2#track_user_signup#5973
Strech merged 1 commit into
masterfrom
appsec-68774-kit-sdk-v2-signup

Conversation

@Strech

@Strech Strech commented Jul 1, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Adds missing functionality to track user signup events to have similar visibility as for login success/failures

Motivation:

Ongoing collaboration with Rubygems.org

Change log entry

Yes. Add signup event tracking to Datadog::Kit::AppSec::Events::V2

Additional Notes:

Interface follow the same guidelines as existing V2 functionality

How to test the change?

CI

@Strech
Strech requested a review from a team as a code owner July 1, 2026 09:51
@dd-octo-sts

dd-octo-sts Bot commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Typing analysis

Note: Ignored files are excluded from the next sections.

Untyped methods

This PR introduces 1 partially typed method, and clears 1 partially typed method. It increases the percentage of typed methods from 65.56% to 65.57% (+0.01%).

Partially typed methods (+1-1) ❌ Introduced: 
sig/datadog/kit/appsec/events/v2.rbs:42
└── def self.set_span_tags: (Datadog::Tracing::SpanOperation span, Hash[Symbol, untyped] tags, namespace: String) -> void
✅ Cleared: 
sig/datadog/kit/appsec/events/v2.rbs:37
└── def self.set_span_tags: (::Datadog::Tracing::SpanOperation span, ::Hash[::Symbol, untyped] tags, namespace: ::String) -> void

If you believe a method or an attribute is rightfully untyped or partially typed, you can add # untyped:accept on the line before the definition to remove it from the stats.

y9v
y9v approved these changes Jul 1, 2026
View reviewed changes

@y9v y9v left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks!

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 1, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4e572476ee

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread sig/datadog/kit/appsec/events/v2.rbs Outdated
Comment thread lib/datadog/kit/appsec/events/v2.rb Outdated
Comment thread sig/datadog/kit/appsec/events/v2.rbs Outdated
@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Jul 1, 2026 •
edited by datadog-official Bot
Loading

Copy link
Copy Markdown

Pipelines  Tests

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 1 Pipeline job failed

Check Pull Request CI Status | all-jobs-are-green   View in Datadog   GitHub Actions

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 90.02% (-0.01%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: eed90f9 | Docs | Datadog PR Page | Give us feedback!

@Strech
Strech force-pushed the appsec-68774-kit-sdk-v2-signup branch from 4e57247 to eed90f9 Compare July 1, 2026 11:17
@Strech
Strech enabled auto-merge July 1, 2026 11:18
@pr-commenter

pr-commenter Bot commented Jul 1, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-07-01 11:43:14

Comparing candidate commit eed90f9 in PR branch appsec-68774-kit-sdk-v2-signup with baseline commit 4550c8e in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 1 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

@Strech
Strech merged commit 49c3134 into master Jul 1, 2026
593 of 595 checks passed
@Strech
Strech deleted the appsec-68774-kit-sdk-v2-signup branch July 1, 2026 12:07
@dd-octo-sts dd-octo-sts Bot added this to the 2.37.0 milestone Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@y9v y9v y9v approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.37.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Strech @y9v