Fix handling of ASM_DD config when ruleset name changes#5970
Conversation
Typing analysisThis PR does not change typing compared to the base branch. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 11edbe787c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Strech
left a comment
Strech
left a comment
There was a problem hiding this comment.
I have few minor suggestions. Thanks for the fix 👍🏼
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: c3e3cca | Docs | Datadog PR Page | Give us feedback! |
11edbe7 to
7852913
Compare
Strech
left a comment
Strech
left a comment
There was a problem hiding this comment.
That approach is way cleaner! Thanks for taking care ❤️
2 participants
What does this PR do?
The Remote Configuration received in AppSec needs to handle deletes before inserts and updates - this prevents errors such as "duplicated rule", since old configs are deleted before new ones are applied.
Motivation:
There were lots of suspicious telemetry errors about duplicated rules in the config, when Remote Config was applied for AppSec.
Change log entry
Yes. AppSec: Fix remote configuration errors when the config name changes.
Additional Notes:
None.
How to test the change?
CI.