Skip to content

chore(libdatadog): bump libdatadog to v33#5723

Merged
gyuheon0h merged 5 commits into
masterfrom
gyuheon0h/bump-libdatadog-v33
May 11, 2026
Merged

chore(libdatadog): bump libdatadog to v33#5723
gyuheon0h merged 5 commits into
masterfrom
gyuheon0h/bump-libdatadog-v33

Conversation

@gyuheon0h

@gyuheon0h gyuheon0h commented May 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?
Bumps libdatadog version to v33. Crashtracker now has errors intake upload by default. The tests are tweaked to account for extra payloads sent.

However, we do not assert heavily on errors intake payload structure, as that is the job of libdatadog to test.

Motivation:
Stay up to date with libdatadog

Change log entry
N/A

Additional Notes:

How to test the change?

@dd-octo-sts

dd-octo-sts Bot commented May 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2026-05-09 06:09:42 UTC

@gyuheon0h Graphite App

gyuheon0h commented May 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@gyuheon0h
gyuheon0h force-pushed the gyuheon0h/bump-libdatadog-v33 branch 3 times, most recently from 19ce80f to d8eb8f8 Compare May 9, 2026 06:07
@gyuheon0h
gyuheon0h marked this pull request as ready for review May 9, 2026 06:07
@gyuheon0h
gyuheon0h requested review from a team as code owners May 9, 2026 06:07
@gyuheon0h
gyuheon0h force-pushed the gyuheon0h/bump-libdatadog-v33 branch from d8eb8f8 to 439f08f Compare May 9, 2026 06:09
@gyuheon0h gyuheon0h changed the title Bump libdatadog to v33 chore(libdatadog): bump libdatadog to v33 May 9, 2026
@gyuheon0h gyuheon0h mentioned this pull request May 9, 2026
Merged
@gyuheon0h
gyuheon0h force-pushed the gyuheon0h/bump-libdatadog-v33 branch from 8c41c13 to 439f08f Compare May 9, 2026 06:13
@pr-commenter

pr-commenter Bot commented May 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-05-11 12:46:38

Comparing candidate commit e134364 in PR branch gyuheon0h/bump-libdatadog-v33 with baseline commit 9582c2e in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 1 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented May 9, 2026 •
edited by datadog-official Bot
Loading

Copy link
Copy Markdown

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 97.13% (-0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e134364 | Docs | Datadog PR Page | Give us feedback!

@eregon

eregon commented May 11, 2026

Copy link
Copy Markdown
Member

A couple jobs didn't pass (dd-gitlab/finished, all-jobs-are-green (pull_request)) so I'll add a merge commit with the GitHub UI to rerun CI.

@gyuheon0h
gyuheon0h enabled auto-merge (squash) May 11, 2026 12:06
@gyuheon0h

gyuheon0h commented May 11, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented May 11, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-05-11 12:07:11 UTC ℹ️ Start processing command /merge

2026-05-11 12:07:26 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-05-11 12:49:52 UTC ℹ️ MergeQueue: This merge request was already merged

This pull request was merged directly.

@gyuheon0h
gyuheon0h merged commit bc0b74d into master May 11, 2026
600 of 603 checks passed
@gyuheon0h
gyuheon0h deleted the gyuheon0h/bump-libdatadog-v33 branch May 11, 2026 12:49
@dd-octo-sts dd-octo-sts Bot added this to the 2.33.0 milestone May 11, 2026
@Strech Strech mentioned this pull request May 13, 2026
Merged
@lloeki lloeki mentioned this pull request Jun 4, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eregon eregon eregon approved these changes
@p-datadog p-datadog p-datadog approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

2.33.0

Development

Successfully merging this pull request may close these issues.

3 participants

@gyuheon0h @eregon @p-datadog