Add Ruby 4.0 to GitLab install-dependencies matrix#5656
Merged
Conversation
The build-image and promote-image matrices already include 4.0; the install-dependencies job was the lone holdout, gated on a TODO that described 4.0 support as premature. With Ruby 4.0 now officially supported, add it to the matrix and drop the TODO.
p-datadog
added
the
AI Generated
p-datadog
added
the
AI Generated
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: d6a6701 | Docs | Datadog PR Page | Give us feedback! |
Member
|
The 4.0 Docker image seems missing somehow, see failed jobs at https://github.com/DataDog/dd-trace-rb/commits/master (and on any new PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
"4.0"to theRUBY_VERSIONmatrix for theinstall-dependenciesjob in.gitlab-ci.yml, and removes the TODO that gated it.Motivation:
The
build-image(line 49) andpromote-image(line 85) matrices already list"4.0". Theinstall-dependenciesjob was the only matrix in this file still missing it, gated on:With Ruby 4.0 now an officially supported runtime (see PR #5655 documenting it in
Compatibility.md), the "premature support" rationale no longer holds and the install-dependencies matrix should match the others.Change log entry
None.
Additional Notes:
Companion to #5655 (docs side of Ruby 4.0 support).
How to test the change?
GitLab CI will run the
install-dependenciesjob forRUBY_VERSION=4.0on bothamd64andarm64. A green pipeline confirms the OCI image builds and resolves dependencies on Ruby 4.0.