Fix process spawn by marcotc · Pull Request #5634 · DataDog/dd-trace-rb

marcotc · 2026-04-23T00:37:49Z

What does this PR do?

Fixes SpawnMonkeyPatch: one-time prepend, super(*inject_envs(args)), merge env_provider when first arg is a Hash, otherwise prepend provider env only (correct MRI inheritance and unsetenv_others).
Uses ::Hash === with a short note ([BUG]: datadog-2.31.0 monkey-patches Process.spawn and interferes with Ferrum #5621 shadowing); adds/keeps regression specs (fork shapes, env output parsing, unsetenv_others).
Renames kwarg to env_provider; RBS apply! → void. Branch includes latest master spawn regression coverage.

Motivation

2.31.0’s Process.spawn patch broke real callers (e.g. Ferrum) and mishandled some MRI env/option cases; we need safe forwarding and no fake full-ENV when unsetenv_others applies.

Change log entry

Yes. Fix Process.spawn monkey patch for MRI-correct env merging (incl. Ferrum-style calls) and unsetenv_others without injecting a synthetic full ENV.

Additional Notes:

Specs use apply!(env_provider: …) to match the new API. See also Fix #5621: TypeError from constant-shadowed Hash check in Process.spawn wrapper #5773 / Drop unused **opts from Process.spawn wrapper signature #5774 on master for related spawn/hash and kwargs-forwarding context.
original PR: chore(telemetry): track process creation via it headers #5464

How to test the change?

bundle exec rspec spec/datadog/core/utils/spawn_monkey_patch_spec.rb
bundle exec rake "steep:check[lib/datadog/core/utils/spawn_monkey_patch.rb,sig/datadog/core/utils/spawn_monkey_patch.rbs]"

dd-octo-sts · 2026-04-23T00:38:01Z

Thank you for updating Change log entry section 👏

^{Visited at: 2026-05-19 16:16:57 UTC}

dd-octo-sts · 2026-04-23T00:50:29Z

Typing analysis

Note: Ignored files are excluded from the next sections.

Untyped methods

This PR introduces 1 untyped method and 1 partially typed method, and clears 1 untyped method and 1 partially typed method.

Untyped methods (+1-1)

❌ Introduced:

sig/datadog/core/utils/spawn_monkey_patch.rbs:11
└── def spawn: (*untyped args) -> untyped

✅ Cleared:

sig/datadog/core/utils/spawn_monkey_patch.rbs:11
└── def spawn: (*untyped args, **untyped opts) -> untyped

Partially typed methods (+1-1)

❌ Introduced:

sig/datadog/core/utils/spawn_monkey_patch.rbs:14
└── def self.inject_envs: (untyped args) -> ::Array[untyped]

✅ Cleared:

sig/datadog/core/utils/spawn_monkey_patch.rbs:14
└── def self.inject_lineage_envs: (untyped args) -> ::Array[untyped]

If you believe a method or an attribute is rightfully untyped or partially typed, you can add # untyped:accept on the line before the definition to remove it from the stats.

mabdinur

Thanks for opening this PR 😄.

Can we update the PR and add a changelog? Also we need to address some failing tests. I'd love to get this fix out as soon as possible

ivoanjo · 2026-05-06T09:09:53Z

Hey @mabdinur @marcotc since this is still an active regression, what's missing to land this?

eregon

The 3 fixes look good (::Hash, no kwargs splitting, not setting extra env vars if user passes unsetenv_others: true).
It's a little bit harder to review because of the rename, that's not ideal for a bug fix PR but not too bad.
From my side I think this is good to go besides adding a test for the unsetenv_others: true since that is a fix that seems not covered with tests currently.

Retain branch Process.spawn refactor (inject_envs, env_provider) and fold in master issue #5621 ::Hash clarification as documentation on inject_envs. Co-authored-by: Cursor <[email protected]>

…ers test Addresses PR review (filter_map for /usr/bin/env parsing, unsetenv_others coverage, apply! typed as void). Co-authored-by: Cursor <[email protected]>

origin/master added fork regression cases with lineage_envs_provider; align with SpawnMonkeyPatch.apply!(env_provider:) and refresh the comment. Co-authored-by: Cursor <[email protected]>

datadog-official · 2026-05-19T16:35:50Z

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 88.24%
• Overall Coverage: 97.09% (-0.00%)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: c7adf84 | Docs | Datadog PR Page | Give us feedback!}

pr-commenter · 2026-05-19T16:40:42Z

Benchmarks

Benchmark execution time: 2026-05-19 16:40:39

Comparing candidate commit c7adf84 in PR branch marco/issue-5621-process-spawn with baseline commit f0cfa4f in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

🟩 = significantly better candidate vs. baseline
🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

…s-test Add mixed Symbol + Integer keys regression test for #5634

marcotc added 5 commits April 22, 2026 17:30

Refactor spawn monkey patch regression specs

622028b

Rename spawn monkey patch env provider

620f6c9

Fix spawn monkey patch env handling

30561aa

Document execute_in_fork alongside expect_in_fork

dd29ca6

Tighten spawn monkey patch array-form spec

5bb8953

dd-octo-sts Bot added the core Involves Datadog core libraries label Apr 23, 2026

marcotc changed the title ~~Marco/issue 5621 process spawn~~ Fix process spawn Apr 23, 2026

Update spawn monkey patch RBS

73d64aa

Fix spawn monkey patch spec lint

567402b

Strech reviewed Apr 23, 2026

View reviewed changes

Comment thread sig/datadog/core/utils/spawn_monkey_patch.rbs Outdated

mabdinur approved these changes Apr 23, 2026

View reviewed changes

Comment thread lib/datadog/core/utils/spawn_monkey_patch.rb Outdated

mabdinur reviewed Apr 23, 2026

View reviewed changes

Comment thread spec/datadog/core/utils/spawn_monkey_patch_spec.rb Outdated

This was referenced May 18, 2026

Fix #5621: TypeError from constant-shadowed Hash check in Process.spawn wrapper #5773

Merged

Drop unused **opts from Process.spawn wrapper signature #5774

Closed

eregon reviewed May 19, 2026

View reviewed changes

Comment thread lib/datadog/core/utils/spawn_monkey_patch.rb

eregon approved these changes May 19, 2026

View reviewed changes

Comment thread lib/datadog/core/utils/spawn_monkey_patch.rb

mabdinur and others added 3 commits May 19, 2026 12:13

Merge origin/master into marco/issue-5621-process-spawn

cb696e4

Retain branch Process.spawn refactor (inject_envs, env_provider) and fold in master issue #5621 ::Hash clarification as documentation on inject_envs. Co-authored-by: Cursor <[email protected]>

Spawn monkey patch: RBS apply! void; spec filter_map and unsetenv_oth…

a1ff5ec

…ers test Addresses PR review (filter_map for /usr/bin/env parsing, unsetenv_others coverage, apply! typed as void). Co-authored-by: Cursor <[email protected]>

fix(spec): use env_provider in #5621 regression examples after merge

c7adf84

origin/master added fork regression cases with lineage_envs_provider; align with SpawnMonkeyPatch.apply!(env_provider:) and refresh the comment. Co-authored-by: Cursor <[email protected]>

mabdinur marked this pull request as ready for review May 19, 2026 16:23

mabdinur requested a review from a team as a code owner May 19, 2026 16:23

mabdinur reviewed May 19, 2026

View reviewed changes

Comment thread lib/datadog/core/utils/spawn_monkey_patch.rb

p-datadog approved these changes May 19, 2026

View reviewed changes

p-datadog mentioned this pull request May 19, 2026

Add mixed Symbol + Integer keys regression test for #5634 #5780

Merged

mabdinur merged commit fb5da24 into master May 19, 2026
589 checks passed

mabdinur deleted the marco/issue-5621-process-spawn branch May 19, 2026 18:37

dd-octo-sts Bot added this to the 2.34.0 milestone May 19, 2026

eregon added a commit that referenced this pull request May 20, 2026

Merge pull request #5780 from DataDog/claude/spawn-5634-add-mixed-key…

68ef1da

…s-test Add mixed Symbol + Integer keys regression test for #5634

Strech mentioned this pull request May 27, 2026

Bump to version 2.34.0 #5815

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix process spawn#5634

Fix process spawn#5634
mabdinur merged 10 commits into
masterfrom
marco/issue-5621-process-spawn

marcotc commented Apr 23, 2026 •

edited by eregon

Loading

Uh oh!

dd-octo-sts Bot commented Apr 23, 2026 •

edited

Loading

Uh oh!

dd-octo-sts Bot commented Apr 23, 2026 •

edited

Loading

Uh oh!

Uh oh!

mabdinur left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

ivoanjo commented May 6, 2026

Uh oh!

Uh oh!

eregon left a comment •

edited

Loading

Uh oh!

Uh oh!

datadog-official Bot commented May 19, 2026 •

edited by datadog-prod-us1-5 Bot

Loading

Uh oh!

pr-commenter Bot commented May 19, 2026

Explanation

More details about the CI and significant changes

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

marcotc commented Apr 23, 2026 • edited by eregon Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dd-octo-sts Bot commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dd-octo-sts Bot commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Typing analysis

Untyped methods

Uh oh!

Uh oh!

mabdinur left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ivoanjo commented May 6, 2026

Uh oh!

Uh oh!

eregon left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

datadog-official Bot commented May 19, 2026 • edited by datadog-prod-us1-5 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter Bot commented May 19, 2026

Benchmarks

Explanation

More details about the CI and significant changes

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

marcotc commented Apr 23, 2026 •

edited by eregon

Loading

dd-octo-sts Bot commented Apr 23, 2026 •

edited

Loading

dd-octo-sts Bot commented Apr 23, 2026 •

edited

Loading

mabdinur left a comment •

edited

Loading

eregon left a comment •

edited

Loading

datadog-official Bot commented May 19, 2026 •

edited by datadog-prod-us1-5 Bot

Loading