Add version 5.x handling for dalli contrib#5435
Merged
Merged
Conversation
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: b79e9f1 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
y9v
approved these changes
Mar 11, 2026
This was referenced Mar 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adjust
dallicontrib to work with breaking changes of version 5.xMotivation:
Resolve #5358
Change log entry
Yes. Fix compatibility with
dalli5.0+Additional Notes:
dalli 5.0 removed
Dalli::Protocol::Binary(and SASL auth) entirely — now onlyDalli::Protocol::Metaexists.How to test the change?
CI