Skip to content

[NO-TICKET] Fix grape endpoint_render for grape 3.x#5414

Merged
vpellan merged 2 commits into
masterfrom
vpellan/fix-grape-3.x
Mar 10, 2026
Merged

[NO-TICKET] Fix grape endpoint_render for grape 3.x#5414
vpellan merged 2 commits into
masterfrom
vpellan/fix-grape-3.x

Conversation

@vpellan

@vpellan vpellan commented Mar 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Fix instrumentation of endpoint_render.grape ActiveSupport notification for grape 3.x (and actually tests grape 3.x on Ruby 4.0)

Motivation:

The comment made by @p-datadog in this PR: #5364

Change log entry

Yes. Fix instrumentation of endpoint_render.grape ActiveSupport notification for grape 3.x.

Additional Notes:

How to test the change?

CI

@vpellan
vpellan requested review from a team as code owners March 3, 2026 12:55
@vpellan
vpellan requested a review from mabdinur March 3, 2026 12:55
@github-actions github-actions Bot added integrations Involves tracing integrations tracing labels Mar 3, 2026
@vpellan vpellan mentioned this pull request Mar 3, 2026
Merged
@pr-commenter

pr-commenter Bot commented Mar 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-03-05 10:05:21

Comparing candidate commit 730c632 in PR branch vpellan/fix-grape-3.x with baseline commit b60e998 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 45 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:library - Gem loading

  • 🟥 throughput [-0.126op/s; -0.088op/s] or [-7.948%; -5.534%]

@vpellan
vpellan force-pushed the vpellan/fix-grape-3.x branch from 146ff57 to 86b89a5 Compare March 4, 2026 13:05
@vpellan
vpellan changed the base branch from master to community/pr-5364 March 4, 2026 13:06
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Mar 4, 2026 •
edited by datadog-datadog-prod-us1-2 Bot
Loading

Copy link
Copy Markdown
Contributor

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 95.12% (+0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 730c632 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@vpellan
vpellan changed the base branch from community/pr-5364 to master March 5, 2026 09:26
@vpellan
vpellan force-pushed the vpellan/fix-grape-3.x branch from 86b89a5 to 730c632 Compare March 5, 2026 09:29
@ivoanjo ivoanjo mentioned this pull request Mar 10, 2026
Closed
@vpellan
vpellan merged commit b8438b6 into master Mar 10, 2026
642 checks passed
@vpellan
vpellan deleted the vpellan/fix-grape-3.x branch March 10, 2026 15:37
@github-actions github-actions Bot added this to the 2.30.0 milestone Mar 10, 2026
@Strech Strech mentioned this pull request Mar 19, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Strech Strech Strech approved these changes
@mabdinur mabdinur mabdinur approved these changes

Assignees

No one assigned

Labels

integrations Involves tracing integrations tracing

Projects

None yet

Milestone

2.30.0

Development

Successfully merging this pull request may close these issues.

3 participants

@vpellan @Strech @mabdinur