Skip to content

Activate integration-specific distributed tracing config through environment variable#5396

Merged
vpellan merged 5 commits into
masterfrom
vpellan/distributed-tracing-integration-configs
Mar 5, 2026
Merged

Activate integration-specific distributed tracing config through environment variable#5396
vpellan merged 5 commits into
masterfrom
vpellan/distributed-tracing-integration-configs

Conversation

@vpellan

@vpellan vpellan commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Follow up to #5360
Add an environment variable for each integration supporting distributed tracing

Motivation:

#5360

Change log entry

Yes. Add DD_TRACE_<INTEGRATION>_DISTRIBUTED_TRACING environment variables for integrations supporting distributed tracing.

Additional Notes:

(I still need to add them to the config registry, for now CI is red but logging off for the evening)

How to test the change?

CI

@github-actions github-actions Bot added core Involves Datadog core libraries integrations Involves tracing integrations tracing labels Feb 26, 2026
@vpellan
vpellan force-pushed the vpellan/distributed-tracing-integration-configs branch from acb0f67 to bc51f4d Compare February 26, 2026 17:28
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Feb 26, 2026 •
edited by datadog-official Bot
Loading

Copy link
Copy Markdown
Contributor

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 95.11% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 39e4950 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@pr-commenter

pr-commenter Bot commented Feb 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-03-02 10:12:11

Comparing candidate commit b8ee266 in PR branch vpellan/distributed-tracing-integration-configs with baseline commit ed07dc9 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 2 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:profiling - profiler gc

  • 🟩 throughput [+15491.213op/s; +16593.704op/s] or [+5.190%; +5.559%]

@vpellan
vpellan marked this pull request as ready for review February 27, 2026 09:13
@vpellan
vpellan requested review from a team as code owners February 27, 2026 09:13
@vpellan
vpellan requested review from mabdinur and marcotc February 27, 2026 09:13
p-datadog
p-datadog approved these changes Feb 27, 2026
View reviewed changes

@p-datadog p-datadog left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI we have a with_env helper to set the environment variables in tests: #5316

@vpellan
vpellan merged commit c3ebed5 into master Mar 5, 2026
653 of 655 checks passed
@vpellan
vpellan deleted the vpellan/distributed-tracing-integration-configs branch March 5, 2026 09:16
@github-actions github-actions Bot added this to the 2.30.0 milestone Mar 5, 2026
@Strech Strech mentioned this pull request Mar 19, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mabdinur mabdinur mabdinur approved these changes
@p-datadog p-datadog p-datadog approved these changes
@marcotc marcotc Awaiting requested review from marcotc
+1 more reviewer
@iadjivon iadjivon iadjivon approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

core Involves Datadog core libraries integrations Involves tracing integrations tracing

Projects

None yet

Milestone

2.30.0

Development

Successfully merging this pull request may close these issues.

4 participants

@vpellan @mabdinur @iadjivon @p-datadog