Skip to content

chore(crashtracking): use unhandled exception API#5391

Closed
gyuheon0h wants to merge 13 commits intographite-base/5391from
gyuheon0h/use-unhandled-exception-api
Closed

chore(crashtracking): use unhandled exception API#5391
gyuheon0h wants to merge 13 commits intographite-base/5391from
gyuheon0h/use-unhandled-exception-api

Conversation

@gyuheon0h
Copy link
Copy Markdown
Contributor

@gyuheon0h gyuheon0h commented Feb 23, 2026

What does this PR do?

This is on top of [PROF-13732 Upgrade libdatadog dependency to version 27.0.0](#5274) currently. Soon, that PR will be updated to be bumping to v28. However, there is a regression in v28, so we should wait until that regression is fixed, then the upgrade PR will be merged, then this can be merged.

Motivation:

Change log entry

Additional Notes:

How to test the change?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 23, 2026

👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2026-03-02 18:45:50 UTC

@github-actions github-actions bot added the core Involves Datadog core libraries label Feb 23, 2026
Copy link
Copy Markdown
Contributor Author

gyuheon0h commented Feb 23, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@gyuheon0h gyuheon0h changed the title Use unhandled exception API chore(crashtracking): use unhandled exception API Feb 23, 2026
@gyuheon0h gyuheon0h changed the base branch from gyuheon0h/libdatadog-v28 to graphite-base/5391 February 23, 2026 10:07
@gyuheon0h gyuheon0h force-pushed the gyuheon0h/use-unhandled-exception-api branch from 49e1b7a to d797a4e Compare February 23, 2026 10:07
@gyuheon0h gyuheon0h force-pushed the gyuheon0h/use-unhandled-exception-api branch from d797a4e to 9e16854 Compare February 23, 2026 10:16
@gyuheon0h gyuheon0h force-pushed the gyuheon0h/use-unhandled-exception-api branch 2 times, most recently from 2d74815 to 3217932 Compare February 24, 2026 10:23
@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Feb 24, 2026

Benchmarks

Benchmark execution time: 2026-03-02 18:52:23

Comparing candidate commit 4dfdcc9 in PR branch gyuheon0h/use-unhandled-exception-api with baseline commit 5ca940e in branch graphite-base/5391.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 42 metrics, 2 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:profiling - Allocations (profiling disabled)

  • 🟩 throughput [+429249.037op/s; +439483.957op/s] or [+9.317%; +9.539%]

scenario:profiling - Allocations (profiling enabled)

  • 🟩 throughput [+423190.209op/s; +431798.389op/s] or [+9.250%; +9.439%]

@gyuheon0h gyuheon0h force-pushed the gyuheon0h/use-unhandled-exception-api branch from 3217932 to 27ea9ec Compare February 24, 2026 12:39
@gyuheon0h gyuheon0h force-pushed the graphite-base/5391 branch from 30c93b0 to 31e40be Compare March 2, 2026 15:53
@gyuheon0h gyuheon0h force-pushed the gyuheon0h/use-unhandled-exception-api branch from 27ea9ec to 1ab3345 Compare March 2, 2026 15:53
@gyuheon0h gyuheon0h force-pushed the gyuheon0h/use-unhandled-exception-api branch from 1ab3345 to 43ba8f8 Compare March 2, 2026 17:58
@gyuheon0h gyuheon0h changed the base branch from graphite-base/5391 to ivoanjo/libdatadog-26-ruby March 2, 2026 17:59
@gyuheon0h gyuheon0h force-pushed the ivoanjo/libdatadog-26-ruby branch from e6ab6f5 to 5ca940e Compare March 2, 2026 18:14
@gyuheon0h gyuheon0h changed the base branch from ivoanjo/libdatadog-26-ruby to graphite-base/5391 March 2, 2026 18:45
@gyuheon0h gyuheon0h closed this Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Involves Datadog core libraries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants