Skip to content

[OpenTracing] Fix distributed tracing signed int ids#539

Merged
delner merged 1 commit into
feature/opentracingfrom
fix/opentracing_signed_int_ids
Sep 14, 2018
Merged

[OpenTracing] Fix distributed tracing signed int ids#539
delner merged 1 commit into
feature/opentracingfrom
fix/opentracing_signed_int_ids

Conversation

@delner

@delner delner commented Sep 13, 2018

Copy link
Copy Markdown
Contributor

Analogous to #530 , OpenTracing was discarding signed integers displayed as negative integers received via distributed tracing from other tracers. This pull request applies the same kind of conversion of signed to unsigned int, to provide compatibility.

@delner delner added bug Involves a bug core Involves Datadog core libraries labels Sep 13, 2018
@delner delner added this to the 0.16.0 milestone Sep 13, 2018
@delner delner self-assigned this Sep 13, 2018
@delner
delner requested a review from pawelchcki September 13, 2018 17:31

@pawelchcki pawelchcki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@delner
delner merged commit 76a1493 into feature/opentracing Sep 14, 2018
@delner
delner deleted the fix/opentracing_signed_int_ids branch September 14, 2018 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Involves a bug core Involves Datadog core libraries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants