[PROF-13732] Enable testing libdatadog-based features on macOS #5351
Merged
[PROF-13732] Enable testing libdatadog-based features on macOS #5351
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
With the upgrade to libdatadog v27 in #5274, we finally have libdatadog builds on rubygems.org. This PR adjusts our testing logic to:
I ended up also de-duplicating some of our helper code, hopefully simplifying how we do this kind of integration.
Motivation:
Make sure libdatadog features are working and keep working on macOS.
Change log entry
Yes. Enable libdatadog-based features on macOS
Additional Notes:
This PR is on top of #5274, so we can only merge it once that one's in good shape.
I don't have a macOS machine available myself, so please let me know if I missed a spot!
How to test the change?
The existing tests are now executed and not skipped on macOS so that should be the validation :)