[PROF-13732] Upgrade libdatadog dependency to version 28.0.2#5274
[PROF-13732] Upgrade libdatadog dependency to version 28.0.2#5274
Conversation
|
Hmm we're hitting the packaging limits, I've ping'd @lloeki for help on that one... |
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 1ea1e8d | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
BenchmarksBenchmark execution time: 2026-03-02 21:04:41 Comparing candidate commit 1ea1e8d in PR branch Found 0 performance improvements and 4 performance regressions! Performance is the same for 40 metrics, 2 unstable metrics.
|
|
Update: We're investigating a possible bug in the profiling reporting code, I'm moving this to draft for now until we confirm it's all good (or else that we need a libdatadog bugfix release) |
|
Update we're treating DataDog/libdatadog#1492 and DataDog/libdatadog#1493 as blockers to getting this merged |
81b55e3 to
0413bfb
Compare
|
Update:
|
|
Update: Libdatadog v27 has now been released. I pushed a commit with the changes needed to make it work, but it's not yet on rubygems -- I tested this on my local machine. |
**What does this PR do?** This PR includes the changes documented in the "Releasing a new version to rubygems.org" part of the README: https://github.com/datadog/libdatadog/tree/main/ruby#releasing-a-new-version-to-rubygemsorg **Motivation:** Enable Ruby to use libdatadog v27.0.0. In particular, this will be the first release where we provide macOS binaries for libdatadog on rubygems.org. **Additional Notes:** N/A **How to test the change?** I've tested this change locally with the changes in DataDog/dd-trace-rb#5274 and was able to get a green test suite run for Ruby. As a reminder, new libdatadog releases don't get automatically picked up by dd-trace-rb, so the PR that bumps the dependency will also test this release against all supported Ruby versions.
# What does this PR do? This PR includes the changes documented in the "Releasing a new version to rubygems.org" part of the README: https://github.com/datadog/libdatadog/tree/main/ruby#releasing-a-new-version-to-rubygemsorg # Motivation: Enable Ruby to use libdatadog v27.0.0. In particular, this will be the first release where we provide macOS binaries for libdatadog on rubygems.org. # Additional Notes: N/A # How to test the change? I've tested this change locally with the changes in DataDog/dd-trace-rb#5274 and was able to get a green test suite run for Ruby. As a reminder, new libdatadog releases don't get automatically picked up by dd-trace-rb, so the PR that bumps the dependency will also test this release against all supported Ruby versions. Co-authored-by: ivo.anjo <[email protected]>
|
Almost there! We have an SSI validation failing:
but otherwise we're good to go. Since I've made quite a few changes after the last reviews, I'm going to dismiss them and ask folks again. |
Added more changes since
|
Update: Vaccine is failing because of DataDog/libdatadog#1498 so that's not a real issue. We're probably going to remove that spec from vaccine or vaccine entirely as we already have test coverage for this in system-tests (e.g. DataDog/system-tests#6275 ) |
|
Arghhh there's some internal discussion in the libdatadog channel that v27 might have another regression :( We should probably hold on this again until we can figure that one out |
|
DataDog/libdatadog#1619 is the current blocker :/ |
d2c6ffa to
b5a8d2f
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
c64957e to
b5a8d2f
Compare
# What does this PR do? This PR includes the changes documented in the "Releasing a new version to rubygems.org" part of the README: https://github.com/datadog/libdatadog/tree/main/ruby#releasing-a-new-version-to-rubygemsorg The v28 release is here: https://github.com/DataDog/libdatadog/releases/tag/v28.0.0 # Motivation Enable Ruby to use libdatadog v28.0.0. **IMPORTANT**: this version will not be merged into main for dd-trace-rb as there is a regression in the profiler exporter in v28. However, we still want to release this version as an an effort to keep a running upgrade version ready. # Additional Notes Anything else we should know when reviewing? # How to test the change? I've tested this change locally with the changes in DataDog/dd-trace-rb#5274 and was able to get a green test suite run for Ruby. As a reminder, new libdatadog releases don't get automatically picked up by dd-trace-rb, so the PR that bumps the dependency will also test this release against all supported Ruby versions. Co-authored-by: gyuheon.oh <[email protected]>
29113a3 to
30c93b0
Compare
# What does this PR do? Packages libdatadog for 28.0.2 gem release. This is useful because this release fixes slow TLS exporter issue that has been delaying [libdatadog upgrade](DataDog/dd-trace-rb#5274) for dd-trace-rb # Motivation What inspired you to submit this pull request? # Additional Notes Anything else we should know when reviewing? # How to test the change? Describe here in detail how the change can be validated. Co-authored-by: gyuheon.oh <[email protected]>
30c93b0 to
31e40be
Compare
5ca940e to
913e09d
Compare
**What does this PR do?** This PR bumps the libdatadog dependency from version 25.0.1.1.0 to version 28.0.2.1.0. This new version cleans up the profile exporting API so I've updated our code to match. Also, this is the first libdatadog version with macOS builds! (Foreshadowing...) **Motivation:** Adopt latest libdadog. **Additional Notes:** N/A **How to test the change?** Green CI is good, as usual. Update lockfiles Bump libdatadog dependency to version 27.0.0 There's a breaking change in profiling (`ddog_prof_ValueType` -> `ddog_prof_SampleType`) + the crashtracking report format changed slightly but otherwise everything looks in good shape. Update lockfiles to use libdatadog 27 [🤖] Lock Dependency: https://github.com/DataDog/dd-trace-rb/actions/runs/21941519831 Update to match libdatadog v27 format for message Minor: Simplify specs Upgrade to v28 [🤖] Lock Dependency: https://github.com/DataDog/dd-trace-rb/actions/runs/22346650666 Bump to 28.0.2.1.0 [🤖] Lock Dependency: https://github.com/DataDog/dd-trace-rb/actions/runs/22583912066
913e09d to
9330399
Compare

What does this PR do?
This PR bumps the libdatadog dependency from version 25.0.1.1.0 to version26.0.0.1.027.0.0.1.0.This PR bumps the libdatadog dependency from version 25.0.1.1.0 to version
28.0.0.1.028.0.2.1.0.This new version cleans up the profile exporting API so I've updated our code to match.
Update: It also changes how the sample types get specified, and the format of the crashtracking message.
Also, this will be the first libdatadog version with macOS builds!
(Foreshadowing...)
Motivation:
Adopt latest libdatadog.
Change log entry
Yes. Upgrade libdatadog dependency to version 28.0.2
Additional Notes:
N/A
How to test the change?
Green CI is good, as usual.