Skip to content

[PROF-13445] Bump minimum version of datadog-ruby_core_source to 3.5.1#5236

Merged
dd-mergequeue[bot] merged 2 commits into
masterfrom
ivoanjo/prof-13445-bump-ruby-core-source-version
Jan 14, 2026
Merged

[PROF-13445] Bump minimum version of datadog-ruby_core_source to 3.5.1#5236
dd-mergequeue[bot] merged 2 commits into
masterfrom
ivoanjo/prof-13445-bump-ruby-core-source-version

Conversation

@ivoanjo

@ivoanjo ivoanjo commented Jan 14, 2026

Copy link
Copy Markdown
Member

What does this PR do?

This PR bumps the minimum version of the datadog-ruby_core_source gem to the latest version (3.5.1), having the usual diff (e.g. #5215 was the previous update).

Motivation:

Doing this bump forces updates to the datadog gem to also pull in the latest version of the datadog-ruby_core_source gem. This ensures users have the best experience and don't e.g. run into issues because somehow they're running the latest version of the gem with an outdated version of the headers.

Specifically version 3.5.1 brings a fix where Ruby 4.0.1 and above would pick the wrong headers to use
(DataDog/datadog-ruby_core_source#25) which could result in crashes or incorrect behavior when using the profiler.

(It also fixes support for Ruby 4.0.0-preview3 but that's not really very interesting.)

Change log entry

Yes. Bump minimum version of datadog-ruby_core_source to 3.5.1

Additional Notes:

This PR is on top of #5234 just to avoid any conflicts when touching the gemfiles but is otherwise completely separate.

How to test the change?

These headers are used by the profiler, so green CI means we're good to go.

I've also manually checked with Ruby 4.0.1, 4.0.0 and some other earlier versions to make sure everything is in good shape.

**What does this PR do?**

This PR bumps the minimum version of the datadog-ruby_core_source gem to
the latest version (3.5.1), having the usual diff (e.g. #5215 was the
previous update).

**Motivation:**

Doing this bump forces updates to the `datadog` gem to also pull in the
latest version of the `datadog-ruby_core_source` gem. This ensures
users have the best experience and don't e.g. run into issues because
somehow they're running the latest version of the gem with an outdated
version of the headers.

Specifically version 3.5.1 brings a fix where Ruby 4.0.1 and above
would pick the wrong headers to use
(DataDog/datadog-ruby_core_source#25)
which could result in crashes or incorrect behavior when using the
profiler.

(It also fixes support for Ruby 4.0.0-preview3 but that's not really
very interesting.)

**Additional Notes:**

This PR is on top of #5234 just to avoid any conflicts when touching
the gemfiles but is otherwise completely separate.

**How to test the change?**

These headers are used by the profiler, so green CI means we're good to go.

I've also manually checked with Ruby 4.0.1, 4.0.0 and some other earlier
versions to make sure everything is in good shape.
@ivoanjo
ivoanjo requested a review from a team as a code owner January 14, 2026 11:39
Base automatically changed from libdatadog-25.0.0 to master January 14, 2026 11:44
@pr-commenter

pr-commenter Bot commented Jan 14, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-01-14 14:17:02

Comparing candidate commit 7111ae0 in PR branch ivoanjo/prof-13445-bump-ruby-core-source-version with baseline commit 8cafb23 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 2 unstable metrics.

@ivoanjo

ivoanjo commented Jan 14, 2026

Copy link
Copy Markdown
Member Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jan 14, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-01-14 13:44:15 UTC ℹ️ Start processing command /merge


2026-01-14 13:44:21 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-01-14 14:19:20 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 26m (p90).


2026-01-14 14:43:54 UTC ℹ️ MergeQueue: This merge request was merged

@datadog-official

datadog-official Bot commented Jan 14, 2026

Copy link
Copy Markdown

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Overall Coverage: 95.21% (-0.01%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7111ae0 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@dd-mergequeue
dd-mergequeue Bot merged commit 40d3486 into master Jan 14, 2026
649 of 650 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the ivoanjo/prof-13445-bump-ruby-core-source-version branch January 14, 2026 14:43
@github-actions github-actions Bot added this to the 2.26.0 milestone Jan 14, 2026
ivoanjo added a commit that referenced this pull request Jan 26, 2026
**What does this PR do?**

This PR bumps the minimum version of the datadog-ruby_core_source gem to
the latest version (3.5.2), having the usual diff (e.g. #5236 was the
previous update).

**Motivation:**

Doing this bump forces updates to the datadog gem to also pull in the
latest version of the datadog-ruby_core_source gem. This ensures users
have the best experience and don't e.g. run into issues because somehow
they're running the latest version of the gem with an outdated version
of the headers.

Specifically version 3.5.2 drops support for the Ruby 4.0.0-preview2
headers, so overall should not impact anyone, while at the same time
having a smaller on-disk footprint
(DataDog/datadog-ruby_core_source#26).

**Additional Notes:**

N/A

**How to test the change?**

Green CI is good!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants