[OpenTracing] Fix symbol propagation#507
Merged
delner merged 2 commits intoAug 10, 2018
Merged
Conversation
pawelchcki
approved these changes
Aug 10, 2018
palazzem
approved these changes
Aug 10, 2018
delner
added a commit
that referenced
this pull request
Aug 17, 2018
* Fixed: Rack headers as symbols incompatible with OpenTracer propagation. * Fixed: Text map baggage as symbols incompatible with OpenTracer propagation.
delner
added a commit
that referenced
this pull request
Sep 13, 2018
* Fixed: Rack headers as symbols incompatible with OpenTracer propagation. * Fixed: Text map baggage as symbols incompatible with OpenTracer propagation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing our Opentracer adapter with
ruby-rack-tracer, we ran into an edge case where when theRack::Envcontains a symbol key, then propagation in our Opentracer adapter raises an errorundefined method 'start_with?' for :"ot-baggage-account_name":Symbol.This pull request coerces symbols to strings when attempting to do this kind of propagation.