[OpenTracing] Tracer start_span and start_active_span implementation#490
Merged
Conversation
delner
added
core
Kyle-Verhoog
approved these changes
Jul 17, 2018
| ignore_active_scope: ignore_active_scope | ||
| ) | ||
|
|
||
| scope_manager.activate(span, finish_on_close: finish_on_close).tap do |scope| |
| # References#CHILD_OF reference to the ScopeManager#active. | ||
| # @return [Span] the newly-started Span instance, which has not been | ||
| # automatically registered via the ScopeManager | ||
| def start_span(operation_name, |
pawelchcki
approved these changes
Jul 17, 2018
pawelchcki
left a comment
pawelchcki
left a comment
Contributor
There was a problem hiding this comment.
Implementation and tests both look good to me 👍
Contributor
Author
|
Thanks for the reviews guys. Think I'm going to add a few more tests to verify basic features (like tags, etc.) |
delner
force-pushed
the
feature/opentracing
branch
from
July 17, 2018 19:57
277294b to
45ab187
Compare
delner
force-pushed
the
feature/opentracing_tracer
branch
from
July 17, 2018 19:57
c7f386c to
b1028be
Compare
delner
force-pushed
the
feature/opentracing_tracer
branch
from
July 17, 2018 20:47
b1028be to
ca4a379
Compare
Contributor
Author
|
Found a small bug where the |
delner
added a commit
that referenced
this pull request
Jul 19, 2018
…490) * Fixed: ThreadLocalScopeManager not passing finish_on_close to scope. * Added: Implementation for OpenTracer::Tracer * Added: OpenTracing::Tracer integration specs.
delner
added a commit
that referenced
this pull request
Aug 9, 2018
…490) * Fixed: ThreadLocalScopeManager not passing finish_on_close to scope. * Added: Implementation for OpenTracer::Tracer * Added: OpenTracing::Tracer integration specs.
delner
added a commit
that referenced
this pull request
Aug 17, 2018
…490) * Fixed: ThreadLocalScopeManager not passing finish_on_close to scope. * Added: Implementation for OpenTracer::Tracer * Added: OpenTracing::Tracer integration specs.
delner
added a commit
that referenced
this pull request
Sep 13, 2018
…490) * Fixed: ThreadLocalScopeManager not passing finish_on_close to scope. * Added: Implementation for OpenTracer::Tracer * Added: OpenTracing::Tracer integration specs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request uses the other components from Datadog::OpenTrace to implement the
start_spanandstart_active_spanfunctions.It does not implement the
injectorextractfunctions, which will come in a separate pull request.