fix: Remove redundant on_error for HTTP integrations#4673
Conversation
|
Thank you for updating Change log entry section 👏 Visited at: 2025-05-21 11:19:50 UTC |
BenchmarksBenchmark execution time: 2025-05-21 14:44:14 Comparing candidate commit 4ad8c15 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 38 metrics, 6 unstable metrics. scenario:profiling - Allocations ()
|
Datadog ReportBranch report: ✅ 0 Failed, 21096 Passed, 1439 Skipped, 3m 45.71s Total Time |
dubloom
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4673 +/- ##
==========================================
- Coverage 97.73% 97.73% -0.01%
==========================================
Files 1442 1442
Lines 87249 87242 -7
Branches 4488 4488
==========================================
- Hits 85276 85263 -13
- Misses 1973 1979 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dubloom
changed the title
8e7d819 to
4ad8c15
Compare
marcotc
changed the title
5 participants
Fixes #4670
What does this PR do?
The
on_errormethod in HTTP integrations was a copy of the defaulton_errorhandler. This PR removes the customon_errorhandler, as it is unnecessary.Motivation:
Before 2.16, a
Methodobject foron_errorwas provided, which raises a warning because the method expects aProc. #4611 introduces a warning to tell the user that theon_errorwas not going to be taken into account. Several customers raised the concern here #4670.Change log entry
Yes. Tracing: Fix: The
on_errorwarning for HTTP instrumentations