DEBUG-3573 Send source code integration tags in telemetry and remote config#4653
Conversation
|
Thank you for updating Change log entry section 👏 Visited at: 2025-05-16 05:36:00 UTC |
|
System tests PR: DataDog/system-tests#3212 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4653 +/- ##
==========================================
- Coverage 97.73% 97.72% -0.01%
==========================================
Files 1441 1442 +1
Lines 87195 87240 +45
Branches 4469 4475 +6
==========================================
+ Hits 85218 85254 +36
- Misses 1977 1986 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Datadog ReportBranch report: ✅ 0 Failed, 21294 Passed, 1378 Skipped, 3m 59.75s Total Time |
p-datadog
changed the title
| # Resets caches in this module. Meant for internal use in the | ||
| # test suite only. | ||
| def _reset |
There was a problem hiding this comment.
I wouldn't add this method for testing purpose only. Can't we call those 2 methods directly in the test suite?
There was a problem hiding this comment.
Maybe there is a way to stub it in the tests instead? I suspect it might be tricky, but I do agree that introducing methods purely for testing purposes is not good practice.
There was a problem hiding this comment.
I would prefer not to stub in this case because then the test ends up not meaningful in my opinion. I could move the reset method in the test suite though.
There was a problem hiding this comment.
In this case remove_instance_variable does not work for module_functions outside of the self scope so I am actually not sure how to get this code to live elsewhere.
5 participants
What does this PR do?
Sends source code integration (SCI) tags in telemetry app-started event and in each remote config request.
Motivation:
Dynamic instrumentation UI requires SCI information in both locations to render properly.
Change log entry
Yes: provide source code integration data to dynamic instrumentation UI
Additional Notes:
How to test the change?
Unit tests added in this PR + system test in DataDog/system-tests#3212