[APPSEC-57237] Handle business logic events#4644
Conversation
Datadog Summary❌ Code Quality ✅ Code Security ✅ Dependencies Test Optimization ReportBranch report: ✅ 0 Failed, 21256 Passed, 1373 Skipped, 3m 57.94s Total Time Was this helpful? Give us feedback! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4644 +/- ##
==========================================
- Coverage 97.77% 97.77% -0.01%
==========================================
Files 1415 1416 +1
Lines 86561 86631 +70
Branches 4386 4391 +5
==========================================
+ Hits 84633 84701 +68
- Misses 1928 1930 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aa9cea3 to
06ae6d7
Compare
* Update system-tests target
06ae6d7 to
baaef72
Compare
BenchmarksBenchmark execution time: 2025-05-13 13:39:58 Comparing candidate commit baaef72 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics. |
5 participants
What does this PR do?
Adds handling of business logic events to be able to finish fingerprinting feature.
Motivation:
The last bits of fingerprinting is to act on business logic events that produced during sign in via auto-instrumentation or SDK.
Change log entry
Yes. AppSec: Add session tracking and fingerprinting support to
deviseandrailscontribs.Additional Notes:
I would like to restructure integration tests to better separate specifically contrib tests from general logic tests. Hence you would see test in the rack contrib (for now)
Second - we have an issue in libddwaf-rb which converts provided
nilvalues into empty strings. Another option is to give a valueinvalidwhich doesn't make much sense, but it is what it is.This is what's new in system-tests
How to test the change?
CI + ST