[OpenTracing] Add OpenTracing configuration#464
Merged
Conversation
delner
force-pushed
the
feature/opentracing_configuration
branch
from
June 14, 2018 20:46
4e6e413 to
9a03595
Compare
delner
force-pushed
the
feature/opentracing_configuration
branch
from
June 15, 2018 17:04
9a03595 to
a840034
Compare
|
|
||
| def initialize(options = {}) | ||
| super() | ||
| @datadog_tracer = Datadog::Tracer.new(options) |
Member
There was a problem hiding this comment.
Is this configuration immutable? If options changes at run-time will we get undefined behaviour?
Contributor
Author
There was a problem hiding this comment.
The options Hash is not immutable. However, if you dig into the code, you'll see it doesn't store the Hash, but copies the values out of the hash and stores them in different variables. So it acts immutable, in that sense.
Kyle-Verhoog
approved these changes
Jun 15, 2018
delner
added a commit
that referenced
this pull request
Jun 22, 2018
* Added: Datadog::OpenTracer::Tracer#datadog_tracer. * Added: Patch for OpenTracing#global_tracer=.
delner
added a commit
that referenced
this pull request
Jul 10, 2018
* Added: Datadog::OpenTracer::Tracer#datadog_tracer. * Added: Patch for OpenTracing#global_tracer=.
delner
added a commit
that referenced
this pull request
Jul 16, 2018
* Added: Datadog::OpenTracer::Tracer#datadog_tracer. * Added: Patch for OpenTracing#global_tracer=.
delner
added a commit
that referenced
this pull request
Jul 17, 2018
* Added: Datadog::OpenTracer::Tracer#datadog_tracer. * Added: Patch for OpenTracing#global_tracer=.
delner
added a commit
that referenced
this pull request
Aug 9, 2018
* Added: Datadog::OpenTracer::Tracer#datadog_tracer. * Added: Patch for OpenTracing#global_tracer=.
delner
added a commit
that referenced
this pull request
Aug 17, 2018
* Added: Datadog::OpenTracer::Tracer#datadog_tracer. * Added: Patch for OpenTracing#global_tracer=.
delner
added a commit
that referenced
this pull request
Sep 13, 2018
* Added: Datadog::OpenTracer::Tracer#datadog_tracer. * Added: Patch for OpenTracing#global_tracer=.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request allows users to configure the
Datadog::OpenTracer::Tracerwith configuration settings to get the most out of their tracer setup.A more abbreviated, practical example might look like: