Skip to content

[APPSEC-57549] Add session tracking and fingerprinting (partial)#4625

Merged
Strech merged 7 commits into
masterfrom
appsec-57549-add-session-tracking-and-fingerprinting
May 7, 2025
Merged

[APPSEC-57549] Add session tracking and fingerprinting (partial)#4625
Strech merged 7 commits into
masterfrom
appsec-57549-add-session-tracking-and-fingerprinting

Conversation

@Strech

@Strech Strech commented May 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

Adds session id tracking and fingerprinting (partial) for Devise

Motivation:

This is a feature required for Account Takeover Protection and Attacker Fingerprinting

Change log entry

Yes. AppSec: Add session tracking for devise contrib.

Additional Notes:

This is a part of many feature, but will be delivered piece-by-piece to reduce the PR size

How to test the change?

CI + ST

@Strech Strech changed the title [APPSEC-57549] Add session tracking and fingerprinting (unconditional) [APPSEC-57549] Add session tracking and fingerprinting (partial) May 6, 2025
@github-actions github-actions Bot added integrations Involves tracing integrations appsec Application Security monitoring product labels May 6, 2025
@codecov-commenter

codecov-commenter commented May 6, 2025 •
edited by codecov Bot
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.94180% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.75%. Comparing base (222a2f7) to head (9e87f46).
⚠️ Report is 2722 commits behind head on master.

Files with missing lines Patch % Lines
...authenticated_single_user_session_tracking_spec.rb 98.80% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4625      +/-   ##
==========================================
- Coverage   97.76%   97.75%   -0.01%     
==========================================
  Files        1411     1412       +1     
  Lines       86059    86236     +177     
  Branches     4342     4348       +6     
==========================================
+ Hits        84137    84303     +166     
- Misses       1922     1933      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented May 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Datadog Report

Branch report: appsec-57549-add-session-tracking-and-fingerprinting
Commit report: 9e87f46
Test service: dd-trace-rb

✅ 0 Failed, 21033 Passed, 1375 Skipped, 3m 37.61s Total Time

@pr-commenter

pr-commenter Bot commented May 6, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-05-07 13:11:12

Comparing candidate commit 9e87f46 in PR branch appsec-57549-add-session-tracking-and-fingerprinting with baseline commit 222a2f7 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@Strech
Strech marked this pull request as ready for review May 7, 2025 09:13
@Strech
Strech requested review from a team as code owners May 7, 2025 09:13
@Strech
Strech force-pushed the appsec-57549-add-session-tracking-and-fingerprinting branch from df74572 to 3413120 Compare May 7, 2025 09:28
y9v
y9v approved these changes May 7, 2025
View reviewed changes

@y9v y9v left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@Strech
Strech force-pushed the appsec-57549-add-session-tracking-and-fingerprinting branch from 3413120 to 9d028ad Compare May 7, 2025 12:32
@Strech
Strech merged commit 65cb319 into master May 7, 2025
@Strech
Strech deleted the appsec-57549-add-session-tracking-and-fingerprinting branch May 7, 2025 13:35
@github-actions github-actions Bot added this to the 2.16.0 milestone May 7, 2025
@Strech Strech mentioned this pull request May 19, 2025
Merged
This was referenced Jul 17, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@y9v y9v y9v approved these changes

Assignees

No one assigned

Labels

appsec Application Security monitoring product integrations Involves tracing integrations

Projects

None yet

Milestone

2.16.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Strech @codecov-commenter @y9v