[OpenTracing] Add skeleton code#462
Merged
Merged
Conversation
delner
added
core
delner
force-pushed
the
feature/opentracing_skeleton
branch
from
June 13, 2018 19:45
950cd5b to
b9666c9
Compare
pawelchcki
requested changes
Jun 14, 2018
pawelchcki
left a comment
pawelchcki
left a comment
Contributor
There was a problem hiding this comment.
One small comment about using rspec filters.
Otherwise this PR looks like good starting point with OpenTracing.
| require 'ddtrace/opentracing' | ||
| require 'ddtrace/opentracing/helper' | ||
|
|
||
| if Datadog::OpenTracing.supported? |
Contributor
There was a problem hiding this comment.
Could this be moved into RSpec filter?
Contributor
Author
There was a problem hiding this comment.
No. The next line below refers to a constant that is undefined if OpenTracing is not supported. We can only load these constants if Ruby >= 2.0.
Kyle-Verhoog
left a comment
Kyle-Verhoog
left a comment
Member
There was a problem hiding this comment.
Everything looks good opentracing-wise. Only the one potential action item with the naming consistency.
| @@ -0,0 +1,23 @@ | |||
| module Datadog | |||
| # Namespace for ddtrace OpenTracing implementation | |||
| module OpenTracing | |||
Member
There was a problem hiding this comment.
In both our python and go opentracing implementations we refer to the tracer and name the sub-module as 'opentracer'.
This is probably not a big deal, but we may wish to be consistent across our implementations.
Contributor
Author
There was a problem hiding this comment.
I see. For consistency with all other Datadog tracers, I'll change OpenTracing to OpenTracer.
| @@ -0,0 +1,6 @@ | |||
| module Datadog | |||
| module OpenTracing | |||
| class Carrier < ::OpenTracing::Carrier | |||
Member
There was a problem hiding this comment.
👍 the python opentracing library does not define a class for the carrier and is assumed to be a dict, this is better.
| require 'ddtrace/opentracing' | ||
| require 'ddtrace/opentracing/helper' | ||
|
|
||
| if Datadog::OpenTracing.supported? |
pawelchcki
approved these changes
Jun 15, 2018
delner
added a commit
that referenced
this pull request
Jun 22, 2018
* Added: opentracing to gemspec. * Added: Opentracing CI tasks. * Added: Datadog::OpenTracer module. * Added: Datadog::OpenTracer spec helpers. * Added: Datadog::OpenTracer::Tracer. * Added: Datadog::OpenTracer::Span. * Added: Datadog::OpenTracer::SpanContext. * Added: Datadog::OpenTracer::Scope. * Added: Datadog::OpenTracer::ScopeManager. * Added: Datadog::OpenTracer::Carrier.
delner
added a commit
that referenced
this pull request
Jul 10, 2018
* Added: opentracing to gemspec. * Added: Opentracing CI tasks. * Added: Datadog::OpenTracer module. * Added: Datadog::OpenTracer spec helpers. * Added: Datadog::OpenTracer::Tracer. * Added: Datadog::OpenTracer::Span. * Added: Datadog::OpenTracer::SpanContext. * Added: Datadog::OpenTracer::Scope. * Added: Datadog::OpenTracer::ScopeManager. * Added: Datadog::OpenTracer::Carrier.
delner
added a commit
that referenced
this pull request
Jul 16, 2018
* Added: opentracing to gemspec. * Added: Opentracing CI tasks. * Added: Datadog::OpenTracer module. * Added: Datadog::OpenTracer spec helpers. * Added: Datadog::OpenTracer::Tracer. * Added: Datadog::OpenTracer::Span. * Added: Datadog::OpenTracer::SpanContext. * Added: Datadog::OpenTracer::Scope. * Added: Datadog::OpenTracer::ScopeManager. * Added: Datadog::OpenTracer::Carrier.
delner
added a commit
that referenced
this pull request
Jul 17, 2018
* Added: opentracing to gemspec. * Added: Opentracing CI tasks. * Added: Datadog::OpenTracer module. * Added: Datadog::OpenTracer spec helpers. * Added: Datadog::OpenTracer::Tracer. * Added: Datadog::OpenTracer::Span. * Added: Datadog::OpenTracer::SpanContext. * Added: Datadog::OpenTracer::Scope. * Added: Datadog::OpenTracer::ScopeManager. * Added: Datadog::OpenTracer::Carrier.
delner
added a commit
that referenced
this pull request
Aug 9, 2018
* Added: opentracing to gemspec. * Added: Opentracing CI tasks. * Added: Datadog::OpenTracer module. * Added: Datadog::OpenTracer spec helpers. * Added: Datadog::OpenTracer::Tracer. * Added: Datadog::OpenTracer::Span. * Added: Datadog::OpenTracer::SpanContext. * Added: Datadog::OpenTracer::Scope. * Added: Datadog::OpenTracer::ScopeManager. * Added: Datadog::OpenTracer::Carrier.
delner
added a commit
that referenced
this pull request
Aug 17, 2018
* Added: opentracing to gemspec. * Added: Opentracing CI tasks. * Added: Datadog::OpenTracer module. * Added: Datadog::OpenTracer spec helpers. * Added: Datadog::OpenTracer::Tracer. * Added: Datadog::OpenTracer::Span. * Added: Datadog::OpenTracer::SpanContext. * Added: Datadog::OpenTracer::Scope. * Added: Datadog::OpenTracer::ScopeManager. * Added: Datadog::OpenTracer::Carrier.
delner
added a commit
that referenced
this pull request
Sep 13, 2018
* Added: opentracing to gemspec. * Added: Opentracing CI tasks. * Added: Datadog::OpenTracer module. * Added: Datadog::OpenTracer spec helpers. * Added: Datadog::OpenTracer::Tracer. * Added: Datadog::OpenTracer::Span. * Added: Datadog::OpenTracer::SpanContext. * Added: Datadog::OpenTracer::Scope. * Added: Datadog::OpenTracer::ScopeManager. * Added: Datadog::OpenTracer::Carrier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request extends OpenTracing components in their most basic form, which are all no-ops. It should act as a starting point for adding code and tests as we begin to implement OpenTracing for
ddtrace.