Avoid method redefinition warning when replacing time providers#4613
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4613 +/- ##
==========================================
- Coverage 97.75% 97.75% -0.01%
==========================================
Files 1417 1417
Lines 86327 86332 +5
Branches 4349 4349
==========================================
+ Hits 84393 84395 +2
- Misses 1934 1937 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Datadog ReportBranch report: ✅ 0 Failed, 21260 Passed, 1373 Skipped, 3m 42.49s Total Time |
marcotc
approved these changes
Apr 28, 2025
Strech
reviewed
Apr 29, 2025
y9v
approved these changes
May 5, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Undefines existing time provider methods before redefining them to avoid the following warnings:
Motivation:
Warning-clean library
Change log entry
Yes: avoid Ruby warnings when providing a custom time provider
Additional Notes:
The method removal is guarded in case customers remove the methods themselves to avoid the warning
How to test the change?
Tested manually by running the relevant examples: