Avoid example redefinition warning in test suite#4612
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4612 +/- ##
==========================================
- Coverage 97.74% 97.74% -0.01%
==========================================
Files 1412 1413 +1
Lines 86256 86170 -86
Branches 4354 4357 +3
==========================================
- Hits 84315 84224 -91
- Misses 1941 1946 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Datadog ReportBranch report: ✅ 0 Failed, 20987 Passed, 1376 Skipped, 3m 36.8s Total Time |
BenchmarksBenchmark execution time: 2025-04-29 12:29:23 Comparing candidate commit c389d79 in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics. scenario:tracing - 100 span trace - no writer
scenario:tracing - Propagation - Trace Context
|
marcotc
approved these changes
Apr 28, 2025
Strech
approved these changes
Apr 29, 2025
Co-authored-by: Sergey Fedorov <[email protected]>
p-datadog
pushed a commit
to p-datadog/dd-trace-rb
that referenced
this pull request
Apr 30, 2025
* master: (25 commits) Continue on error Comment on Gemfile Run CI Avoid example redefinition warning in test suite (DataDog#4612) [NO-TICKET] Decouple environment variable from programmatic config precedence (DataDog#4610) Update rack/rails/sinatra to use security events Rewrite Event.record logic for non-attack events Warn when ignoring on_error argument due to it not being a proc (DataDog#4611) Bump the gh-actions-packages group across 3 directories with 6 updates Update Event to use SecurityEvent class Replace events with new SecurityEvent class Add new class SecurityEvent Rename AppSec API security method Rewrite Event#record public interface Add attack headers test to the rails contib Remove unused keys from the events Add new test scenarios for security event Change visibility of Event internal methods Rewrite Event#record specs Return complete rule files into assets ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors the examples to avoid this warning:
Motivation:
Warning-clean test suite
Change log entry
None
Additional Notes:
N/A
How to test the change?
Tested manually by running the relevant examples: