Skip to content

Replace JSON.fast_generate with JSON.generate#4602

Merged
TonyCTHsu merged 1 commit into
masterfrom
tonycthsu/json-generate
Apr 24, 2025
Merged

Replace JSON.fast_generate with JSON.generate#4602
TonyCTHsu merged 1 commit into
masterfrom
tonycthsu/json-generate

Conversation

@TonyCTHsu

@TonyCTHsu TonyCTHsu commented Apr 24, 2025

Copy link
Copy Markdown
Collaborator

Motivation:

After JSON release 2.11.0, we found this failure:

https://github.com/DataDog/dd-trace-rb/actions/runs/14641122329/job/41083646804

What

Replace JSON.fast_generate with JSON.generate

Change log entry
Yes. Fix ArgumentError from JSON.fast_generate for old Ruby version

@TonyCTHsu
TonyCTHsu requested review from a team as code owners April 24, 2025 13:03
@TonyCTHsu TonyCTHsu added the profiling Involves Datadog profiling label Apr 24, 2025
@TonyCTHsu TonyCTHsu added this to the 2.16.0 milestone Apr 24, 2025
@github-actions

github-actions Bot commented Apr 24, 2025

Copy link
Copy Markdown

Thank you for updating Change log entry section 👏

Visited at: 2025-04-24 13:13:52 UTC

@Strech

Strech commented Apr 24, 2025

Copy link
Copy Markdown
Member

@TonyCTHsu check the bot message plz

@datadog-datadog-prod-us1

Copy link
Copy Markdown
Contributor

Datadog Report

Branch report: tonycthsu/json-generate
Commit report: cab87dc
Test service: dd-trace-rb

✅ 0 Failed, 20835 Passed, 1373 Skipped, 3m 42.55s Total Time

@codecov-commenter

codecov-commenter commented Apr 24, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (5de3de1) to head (cab87dc).
Report is 359 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4602      +/-   ##
==========================================
- Coverage   97.77%   97.77%   -0.01%     
==========================================
  Files        1409     1409              
  Lines       86183    86182       -1     
  Branches     4352     4352              
==========================================
- Hits        84265    84261       -4     
- Misses       1918     1921       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter

pr-commenter Bot commented Apr 24, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-04-24 13:26:14

Comparing candidate commit cab87dc in PR branch tonycthsu/json-generate with baseline commit 5de3de1 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@ivoanjo ivoanjo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for fixing this

@TonyCTHsu
TonyCTHsu merged commit b3f7d09 into master Apr 24, 2025
@TonyCTHsu
TonyCTHsu deleted the tonycthsu/json-generate branch April 24, 2025 13:52
@Strech Strech mentioned this pull request May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

profiling Involves Datadog profiling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants