Replace JSON.fast_generate with JSON.generate#4602
Merged
Conversation
|
Thank you for updating Change log entry section 👏 Visited at: 2025-04-24 13:13:52 UTC |
Strech
approved these changes
Apr 24, 2025
Member
|
@TonyCTHsu check the bot message plz |
Contributor
Datadog ReportBranch report: ✅ 0 Failed, 20835 Passed, 1373 Skipped, 3m 42.55s Total Time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4602 +/- ##
==========================================
- Coverage 97.77% 97.77% -0.01%
==========================================
Files 1409 1409
Lines 86183 86182 -1
Branches 4352 4352
==========================================
- Hits 84265 84261 -4
- Misses 1918 1921 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
After JSON release 2.11.0, we found this failure:
https://github.com/DataDog/dd-trace-rb/actions/runs/14641122329/job/41083646804
What
Replace JSON.fast_generate with JSON.generate
Change log entry
Yes. Fix ArgumentError from JSON.fast_generate for old Ruby version