[PROF-11680] Add support for profiling Ruby 3.5.0-preview1#4600
Merged
Conversation
**What does this PR do?** This PR adds support for profiling Ruby 3.5.0-preview1. The only work needed was importing the latest headers in DataDog/datadog-ruby_core_source#15 so this PR adds the new 3.4.1 release of the headers as the minimum version allowed. **Motivation:** By setting the minimum version of `datadog-ruby_core_source` to the latest release, we make sure bundler picks it up, and doesn't try to use an incorrect release with Ruby 3.5. **Additional Notes:** N/A **How to test the change?** We don't yet test with 3.5 on CI; I tested locally that the profiler test suite is working fine with 3.4 and 3.5.
ivoanjo
changed the title
BenchmarksBenchmark execution time: 2025-04-24 14:43:54 Comparing candidate commit 69164d4 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics. |
Contributor
Datadog ReportBranch report: ✅ 0 Failed, 20837 Passed, 1373 Skipped, 3m 42.34s Total Time |
Strech
approved these changes
Apr 24, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4600 +/- ##
=======================================
Coverage 97.73% 97.73%
=======================================
Files 1411 1411
Lines 86225 86225
Branches 4354 4354
=======================================
+ Hits 84269 84274 +5
+ Misses 1956 1951 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
p-datadog
approved these changes
Apr 24, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for profiling Ruby 3.5.0-preview1. The only work needed was importing the latest headers in
DataDog/datadog-ruby_core_source#15 so this PR adds the new 3.4.1 release of the headers as the minimum version allowed.
Motivation:
By setting the minimum version of
datadog-ruby_core_sourceto the latest release, we make sure bundler picks it up, and doesn't try to use an incorrect release with Ruby 3.5.Change log entry
Yes. Add support for profiling Ruby 3.5.0-preview1
Additional Notes:
N/A
How to test the change?
We don't yet test with 3.5 on CI; I tested locally that the profiler test suite is working fine with 3.4 and 3.5.