[APMAPI-1116] Stable configuration by vpellan · Pull Request #4592 · DataDog/dd-trace-rb

vpellan · 2025-04-17T15:47:58Z

What does this PR do?

Add stable config support.

Motivation:

Fleet Automation will inject a configuration file onto hosts that the APM SDKs must read, apply, and report telemetry about

Change log entry

None.

Additional Notes:

Needs to wait for libdatadog 17.1 release because of ddog_library_configurator_with_detect_process_info, so critical code is commented out.

How to test the change?

System-tests, following the instructions here

datadog-datadog-prod-us1 · 2025-04-17T16:02:14Z

Datadog Report

Branch report: vpellan/stable-configuration
Commit report: 8305bbc
Test service: dd-trace-rb

✅ 0 Failed, 23500 Passed, 1498 Skipped, 3m 57.47s Total Time

ivoanjo

Left a few notes :)

codecov-commenter · 2025-05-12T08:21:32Z

Codecov Report

Attention: Patch coverage is 95.45455% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.77%. Comparing base (df9dba8) to head (8305bbc).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
lib/datadog/core/configuration/stable_config.rb	81.81%	2 Missing ⚠️
lib/datadog/core/configuration/option.rb	96.55%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4592   +/-   ##
=======================================
  Coverage   97.77%   97.77%           
=======================================
  Files        1419     1421    +2     
  Lines       86624    86676   +52     
  Branches     4397     4404    +7     
=======================================
+ Hits        84697    84750   +53     
+ Misses       1927     1926    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pr-commenter · 2025-05-12T08:22:47Z

Benchmarks

Benchmark execution time: 2025-05-14 21:31:19

Comparing candidate commit 8305bbc in PR branch vpellan/stable-configuration with baseline commit df9dba8 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

datadog-datadog-prod-us1 · 2025-05-12T14:34:16Z

Datadog Summary

❌ Code Quality ✅ Code Security ✅ Dependencies

Test Optimization Report

Branch report: vpellan/stable-configuration
Commit report: c6ed4a9
Test service: dd-trace-rb

✅ 0 Failed, 21260 Passed, 1373 Skipped, 3m 51.18s Total Time

Was this helpful? Give us feedback!

…igVec to Datadog::Core::Configuration::StableConfigVec

- Make Configurator.get always return a hash - Combine Configurator new and get

ivoanjo reviewed Apr 23, 2025

View reviewed changes

vpellan force-pushed the vpellan/stable-configuration branch from 8a1edbd to da8b0c1 Compare April 24, 2025 12:06

github-actions Bot added the profiling Involves Datadog profiling label Apr 24, 2025

ivoanjo reviewed Apr 24, 2025

View reviewed changes

Comment thread ext/libdatadog_api/library_config.c Outdated

Comment thread ext/libdatadog_api/library_config.c Outdated

vpellan mentioned this pull request Apr 28, 2025

[NO-TICKET] Decouple environment variable from programmatic config precedence #4610

Merged

vpellan force-pushed the vpellan/stable-configuration branch from 2bdd7bd to f189316 Compare April 28, 2025 15:56

github-actions Bot added the core Involves Datadog core libraries label Apr 28, 2025

vpellan force-pushed the vpellan/stable-configuration branch 2 times, most recently from f819739 to 44876eb Compare May 2, 2025 10:45

vpellan mentioned this pull request May 6, 2025

[NO-TICKET] Separate set_value_from_env_or_default in two methods and always set default option value #4627

Merged

vpellan force-pushed the vpellan/stable-configuration branch from 44876eb to 6af044a Compare May 7, 2025 14:33

github-actions Bot added the appsec Application Security monitoring product label May 7, 2025

vpellan force-pushed the vpellan/stable-configuration branch 3 times, most recently from 641cf63 to 22f2401 Compare May 12, 2025 07:34

vpellan changed the title ~~[APMAPI-1116] [WIP] Stable configuration~~ [APMAPI-1116] Stable configuration May 12, 2025

vpellan marked this pull request as ready for review May 12, 2025 08:11

vpellan requested review from a team as code owners May 12, 2025 08:11

p-datadog reviewed May 12, 2025

View reviewed changes

Comment thread lib/datadog/core/configuration/stable_config.rb Outdated

vpellan force-pushed the vpellan/stable-configuration branch 2 times, most recently from c3a75b9 to c6ed4a9 Compare May 12, 2025 14:31

vpellan force-pushed the vpellan/stable-configuration branch from c6ed4a9 to e0bd658 Compare May 12, 2025 16:13

marcotc reviewed May 12, 2025

View reviewed changes

Comment thread lib/datadog/core/configuration.rb Outdated

marcotc reviewed May 12, 2025

View reviewed changes

Comment thread lib/datadog/core/configuration/stable_config.rb Outdated

marcotc reviewed May 12, 2025

View reviewed changes

Comment thread lib/datadog/core/configuration/stable_config.rb Outdated

vpellan added 25 commits May 14, 2025 21:31

Add stable configuration C API

6cfe3e6

Sync datadog_ruby_common between extensions

9a5df57

Replace error by warning

cc05b73

Replace rb_intern2 by rb_to_symbol

97eae6d

Merge configurator new and init functions

3b8a38c

Add ddog_Vec_LibraryConfig memory management

a296bdc

Rename LibraryConfig to StableConfig and changed it to Module

e16e148

Add StableConfig::Configurator rbs

f00d458

Add comment and RB_GC_GUARD for ConfigVec ruby object

8baa073

Add Fleet and Local stable config precedence values

0dfa83b

Add stable config module

ee129b2

Change result type of Configurator.get

d62b467

Apply customer and fleet config to options

8957a09

Fix stable config when native lib does not return a hash

2019108

Remove stable_config/configurator.rbs

4375861

Add tests

4544274

Add test for debug log in case libdatadog is not available

c634ceb

Use separate logger if configuration is not initialized

1d5c02d

Change MultipleComparison cop threshold to 3

7a79b90

Add config_init_logger for logging during configuration initalization

6b99c2f

Move is_config_loaded and log_warning_without_config to library_config.h

9e9c695

Add config_vec_class as global variable and include library_config.h

bc23407

Rename Datadog::Core::Configuration::StableConfig::Configurator::Conf…

cde46d4

…igVec to Datadog::Core::Configuration::StableConfigVec

- Replace module_function by self

77e995d

- Make Configurator.get always return a hash - Combine Configurator new and get

Disable stable config

8305bbc

vpellan force-pushed the vpellan/stable-configuration branch 2 times, most recently from 6e20a26 to 8305bbc Compare May 14, 2025 21:07

vpellan merged commit 2a00553 into master May 14, 2025

vpellan deleted the vpellan/stable-configuration branch May 14, 2025 21:51

github-actions Bot added this to the 2.16.0 milestone May 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[APMAPI-1116] Stable configuration#4592

[APMAPI-1116] Stable configuration#4592
vpellan merged 27 commits into
masterfrom
vpellan/stable-configuration

vpellan commented Apr 17, 2025 •

edited

Loading

Uh oh!

datadog-datadog-prod-us1 Bot commented Apr 17, 2025 •

edited

Loading

Uh oh!

ivoanjo left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented May 12, 2025 •

edited

Loading

Uh oh!

pr-commenter Bot commented May 12, 2025 •

edited

Loading

Uh oh!

Uh oh!

datadog-datadog-prod-us1 Bot commented May 12, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

vpellan commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

datadog-datadog-prod-us1 Bot commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Datadog Report

Uh oh!

ivoanjo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pr-commenter Bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Uh oh!

Uh oh!

datadog-datadog-prod-us1 Bot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Datadog Summary

Test Optimization Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vpellan commented Apr 17, 2025 •

edited

Loading

datadog-datadog-prod-us1 Bot commented Apr 17, 2025 •

edited

Loading

codecov-commenter commented May 12, 2025 •

edited

Loading

pr-commenter Bot commented May 12, 2025 •

edited

Loading

datadog-datadog-prod-us1 Bot commented May 12, 2025 •

edited

Loading