Fix GraphQL patchers 'require' issue#3813
Conversation
|
Is it supported to load datadog first and graphql second, as well as the other way around? We already have tests like https://github.com/DataDog/dd-trace-rb/blob/master/spec/loading_spec.rb that start with a clean environment, given that this was a customer-reported issue I would consider adding a test that verifies that the reported case works correctly going forward. |
BenchmarksBenchmark execution time: 2024-08-05 18:32:43 Comparing candidate commit 6f6ce3e in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. |
497b58d to
7891bba
Compare
Hello! Thanks for the suggestions. |
There was a problem hiding this comment.
I would think that adding require 'shellwords' in this file is necessary so that it can be executed by itself? The only other place that requires this library is the top-level loading test that I can see.
There was a problem hiding this comment.
Thanks for the suggestion, I've added it !
6229289 to
6f6ce3e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3813 +/- ##
==========================================
- Coverage 97.87% 97.86% -0.01%
==========================================
Files 1262 1263 +1
Lines 75653 75738 +85
Branches 3710 3719 +9
==========================================
+ Hits 74044 74124 +80
- Misses 1609 1614 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What does this PR do?
Making a custom tracer based on unified_tracer should now not need to require explicitly the unified_tracer.rb file anymore. This also fixes the problem with currently unreleased appsec_tracer.
Motivation:
Fixes issue #3804
Additional Notes:
How to test the change?
Create a Rails + GraphQL app with a custom tracer that includes unified_tracer. GraphQL AppSec test app is using this so if system-tests passes, it works.
Unsure? Have a question? Request a review!