Conversation
Signed-off-by: Marco Costa <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3789 +/- ##
=======================================
Coverage 97.91% 97.91%
=======================================
Files 1246 1246
Lines 74999 75029 +30
Branches 3627 3629 +2
=======================================
+ Hits 73435 73466 +31
+ Misses 1564 1563 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TonyCTHsu
approved these changes
Jul 17, 2024
TonyCTHsu
left a comment
TonyCTHsu
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for adding the types as well!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Populate additional DBM SQL comment propagation values to provide enough information to enable Inferred Service dependencies for databases.
Additional Notes:
See internal Slack for further documentation for this implementation.
How to test the change?
All changes are covered by tests.