[SDTEST-184] Agentless telemetry#3779
Merged
Merged
Conversation
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
… a factory method
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3779 +/- ##
========================================
Coverage 97.91% 97.91%
========================================
Files 1246 1246
Lines 74999 75122 +123
Branches 3627 3633 +6
========================================
+ Hits 73436 73558 +122
- Misses 1563 1564 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2024-07-22 13:51:26 Comparing candidate commit f8966a7 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. |
anmarchenko
marked this pull request as ready for review
July 17, 2024 08:56
ivoanjo
approved these changes
Jul 17, 2024
ivoanjo
left a comment
ivoanjo
left a comment
Member
There was a problem hiding this comment.
Left a bunch of notes and suggestions, but overall it LGTM 👍
…ng to resolve it internally again
…wn factory method
… agentless URL for testing purposes
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds configurable agentless mode and configurable shutdown timeout to telemetry
Motivation:
Test visibility library runs in agentless mode more often than with Datadog agent, so we need agentless mode for telemetry to submit metrics.
Configurable shutdown timeout will help us to make sure that all metrics will be flushed when test suite finishes.
How to test the change?
Unit tests are provided. In parallel to review process I am going to work on POC for sending telemetry from test visibility instrumentation to test this end2end.