Add sampling by trace tags#3587
Merged
Merged
Conversation
Signed-off-by: Marco Costa <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3587 +/- ##
========================================
Coverage 98.24% 98.25%
========================================
Files 1254 1255 +1
Lines 74375 74545 +170
Branches 3529 3537 +8
========================================
+ Hits 73073 73241 +168
- Misses 1302 1304 +2 ☔ View full report in Codecov by Sentry. |
estherk15
approved these changes
Apr 15, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR expands the sampling rule engine to allow for matching on traces based on their tags and metrics.
In
ddtrace, both tags (string value) and metrics (float value) are calledtags, but the matcher has a few implementation details that makes it work with both.How to test the change?
There are unit tests in this PR, as well as system tests: https://github.com/DataDog/system-tests/blob/373c58b012da02794385510cb083001f5a0b9013/tests/parametric/test_trace_sampling.py#L302
Unsure? Have a question? Request a review!