Add sampling by trace resource#3585
Merged
Merged
Conversation
Signed-off-by: Marco Costa <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3585 +/- ##
=======================================
Coverage 98.24% 98.24%
=======================================
Files 1254 1254
Lines 74355 74414 +59
Branches 3529 3529
=======================================
+ Hits 73052 73111 +59
Misses 1303 1303 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TonyCTHsu
approved these changes
Apr 12, 2024
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR expands the sampling rule engine to allow for matching on traces based on their resource names.
Additional Notes:
How to test the change?
There are unit tests in this PR, as well as system tests: https://github.com/DataDog/system-tests/blob/373c58b012da02794385510cb083001f5a0b9013/tests/parametric/test_trace_sampling.py#L195
Unsure? Have a question? Request a review!