Use strict base64 encoding (no newline)#3565
Merged
Merged
Conversation
github-actions
Bot
added
appsec
ivoanjo
approved these changes
Apr 2, 2024
ivoanjo
left a comment
ivoanjo
left a comment
Member
There was a problem hiding this comment.
👍 LGTM
I wonder if we should introduce a helper method for this -- not to avoid repeating code (it's one line), but because we wouldn't have to keep "remembering" to use the correct variant of base64 (although we'd need to remember to use the helper ;D )
lloeki
force-pushed
the
fix-base64-encode
branch
from
April 3, 2024 11:02
3a21d4b to
e312cbf
Compare
Member
Author
The correct version depends on what you're doing. It just turns out that the changes here all use the non-MIME one but it's really a case by case.
So true. It's also less explicit, hiding the fact that should be in plain sight and in context. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2.0 Upgrade Guide notes
What does this PR do?
Use strict base64 encoding.
Motivation:
MIME-style newlines in the middle of base64 makes for some unhappy results.
Additional Notes:
Reported case was with compressed data on appsec derivative results (e.g schema), introduced in 8c52213
This also applies to a few areas like RC capabilities, although the contents was smaller thus not affected (a trailing newline was handled with a
chomp.How to test the change?
CI covers it (added a non-regression test)
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!