Skip to content

on_error settings for grape#3370

Merged
TonyCTHsu merged 13 commits into2.0from
tonycthsu/grape-on-error-2.0
Jan 10, 2024
Merged

on_error settings for grape#3370
TonyCTHsu merged 13 commits into2.0from
tonycthsu/grape-on-error-2.0

Conversation

@TonyCTHsu
Copy link
Copy Markdown
Contributor

@TonyCTHsu TonyCTHsu commented Jan 8, 2024 •
edited by marcotc
Loading

2.0 Upgrade Guide notes

🚨 Breaking change for Grape instrumentation:

Replace error_statuses with error_status_codes. Change your configuration from string to array of ranges or integers.

For example:

Before:

Datadog.configure do |c|
  c.tracing.instrument :grape, error_statuses: '400,500-599'
end

After:

Datadog.configure do |c|
  c.tracing.instrument :grape, error_status_codes: [400, 500..599]
end

What does this PR do?

  1. Add on_error settings for grape instrumentation
  2. Replace error_statuses with error_status_codes settings for grape instrumentation

@TonyCTHsu TonyCTHsu changed the base branch from master to 2.0 January 8, 2024 15:40
@github-actions github-actions Bot added integrations Involves tracing integrations tracing labels Jan 8, 2024
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6ea3035) 98.10% compared to head (6ea3035) 98.10%.

❗ Current head 6ea3035 differs from pull request most recent head a7405cd. Consider uploading reports for the commit a7405cd to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##              2.0    #3370   +/-   ##
=======================================
  Coverage   98.10%   98.10%           
=======================================
  Files        1250     1250           
  Lines       72377    72377           
  Branches     3394     3394           
=======================================
  Hits        71009    71009           
  Misses       1368     1368

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TonyCTHsu TonyCTHsu marked this pull request as ready for review January 8, 2024 20:33
@TonyCTHsu TonyCTHsu requested review from a team as code owners January 8, 2024 20:33
@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/grape-on-error-2.0 branch from 05c0554 to 2e17696 Compare January 8, 2024 20:42
brett0000FF
brett0000FF approved these changes Jan 8, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small style nits changing to present tense, avoiding temporal words, and fixing spacing before parenthetical. 👍

Comment thread docs/GettingStarted.md Outdated
Comment thread docs/GettingStarted.md Outdated
Comment thread docs/GettingStarted.md Outdated
Comment thread docs/GettingStarted.md Outdated
Comment thread docs/GettingStarted.md Outdated
Comment thread docs/GettingStarted.md Outdated
@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/grape-on-error-2.0 branch from 8f1c670 to af2af87 Compare January 10, 2024 12:47
@TonyCTHsu TonyCTHsu linked an issue Jan 10, 2024 that may be closed by this pull request
Exceptions captured with rescue_from :all still appear in Error Tracking when using Grape integration #3253
Closed
@TonyCTHsu TonyCTHsu mentioned this pull request Jan 10, 2024
Merged
2 tasks
@TonyCTHsu TonyCTHsu merged commit dede2de into 2.0 Jan 10, 2024
@TonyCTHsu TonyCTHsu deleted the tonycthsu/grape-on-error-2.0 branch January 10, 2024 14:33
@TonyCTHsu TonyCTHsu added this to the 2.0 milestone Feb 20, 2024
@ivoanjo ivoanjo added the 2.0 label Mar 14, 2024
@TonyCTHsu TonyCTHsu modified the milestones: 2.0, 2.0.0.beta1 Mar 22, 2024
This was referenced Apr 12, 2024
Closed
Closed
Merged
Merged
@TonyCTHsu TonyCTHsu mentioned this pull request Jun 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcotc marcotc marcotc approved these changes

@brett0000FF brett0000FF brett0000FF approved these changes

Assignees

No one assigned

Labels

2.0 integrations Involves tracing integrations tracing

Projects

None yet

Milestone

2.0.0.beta1

Development

Successfully merging this pull request may close these issues.

Exceptions captured with rescue_from :all still appear in Error Tracking when using Grape integration

5 participants

@TonyCTHsu @codecov-commenter @marcotc @brett0000FF @ivoanjo